Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ripple: Uncaught ReferenceError: isTouching is not defined #3593

Closed
KOliver94 opened this issue Nov 8, 2022 · 1 comment · Fixed by #3594
Closed

Ripple: Uncaught ReferenceError: isTouching is not defined #3593

KOliver94 opened this issue Nov 8, 2022 · 1 comment · Fixed by #3594
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@KOliver94
Copy link
Contributor

KOliver94 commented Nov 8, 2022

Describe the bug

In mobile view Ripple throws the following exception to the console everytime a user click on something that has ripple effect:
Uncaught ReferenceError: isTouching is not defined at HTMLButtonElement.onTouchStart2

I have not checked the issue in other browsers other than Chrome.

The code part causing the issue was introduced by #3530.

Reproducer

https://codesandbox.io/s/quirky-panna-rikdyx

PrimeReact version

8.7.1

React version

18.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

Chrome 107.0.5304.87

Steps to reproduce the behavior

  1. Open the CodeSandbox generated page in a new browser tab in Chrome.
  2. Open Developer Tools (F12)
  3. Toggle device toolbar and set for example the dimensions of an iPhone SE
  4. Refresh the page
  5. Click on the Calendar icon
  6. See the error message logged in the console

Expected behavior

No exception should be thrown.

@KOliver94 KOliver94 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 8, 2022
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 8, 2022
@melloware melloware self-assigned this Nov 8, 2022
@melloware melloware added this to the 8.7.2 milestone Nov 8, 2022
melloware added a commit to melloware/primereact that referenced this issue Nov 8, 2022
@melloware
Copy link
Member

Whoops that was a leftover line of code. I removed it! Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants