Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datatable: customRestoreState columnReordering duplicates columns #3470

Closed
njsdev opened this issue Oct 11, 2022 · 2 comments · Fixed by #3472
Closed

Datatable: customRestoreState columnReordering duplicates columns #3470

njsdev opened this issue Oct 11, 2022 · 2 comments · Fixed by #3472
Labels
Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response Type: Bug Issue contains a defect related to a specific component.

Comments

@njsdev
Copy link

njsdev commented Oct 11, 2022

Describe the bug

See codesandbox, when columns are reordered, duplicate columns are added

https://codesandbox.io/s/bold-grass-8fti1r?file=/src/demo/DataTableStateDemo.js

Reproducer

https://codesandbox.io/s/bold-grass-8fti1r?file=/src/demo/DataTableStateDemo.js

PrimeReact version

8.6.1

React version

17.x

Language

ES6

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

  1. Open attached codesandbox
  2. drag a column to reorder. You'll see that the name column is duplicated and appears 3 times.

Expected behavior

Columns should not be duplicated when re-ordered
@njsdev njsdev added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 11, 2022
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 11, 2022
@melloware melloware self-assigned this Oct 11, 2022
@melloware melloware added this to the 8.6.2 milestone Oct 11, 2022
melloware added a commit to melloware/primereact that referenced this issue Oct 11, 2022
@melloware
Fix primefaces#3470: Datatable custom restore state column fix
c357081
@melloware melloware mentioned this issue Oct 11, 2022
Merged
melloware added a commit to melloware/primereact that referenced this issue Oct 11, 2022
@melloware
Fix primefaces#3470: Datatable custom restore state column fix
5fc104f
melloware added a commit that referenced this issue Oct 11, 2022
@melloware
Fix #3470: Datatable custom restore state column fix (#3472)
c2159cb
@melloware melloware reopened this Oct 11, 2022
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 11, 2022
@melloware melloware removed this from the 8.6.2 milestone Oct 11, 2022
@melloware melloware removed their assignment Oct 11, 2022
@melloware melloware reopened this Oct 12, 2022
melloware added a commit that referenced this issue Oct 12, 2022
@melloware
Revert "Fix #3470: Datatable custom restore state column fix (#3472)"
bacd093 
This reverts commit c2159cb.
@melloware melloware reopened this Oct 12, 2022
@melloware melloware removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 26, 2023
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale. If this issue is still affecting you with the latest version, please leave any comment, and we will keep it open. We are sorry that we have not been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@github-actions github-actions bot added the Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response label Nov 21, 2024
@github-actions GitHub Actions
Copy link

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you for your understanding!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3470: Datatable custom restore state column fix melloware/primereact
2 participants
@melloware @njsdev