Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoComplete: space between overlay panel and the component #3463

Closed
pascualmj opened this issue Oct 10, 2022 · 4 comments · Fixed by #3741
Closed

AutoComplete: space between overlay panel and the component #3463

pascualmj opened this issue Oct 10, 2022 · 4 comments · Fixed by #3741
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@pascualmj
Copy link

Describe the bug

When searching for an option, the overlay panel shows up on top of the autocomplete component (cause it has no space below to be placed), and that's fine, but when I continue typing, less options appear and the overlay panel sticks to the same top position value. So that generates an annoying space between the overlay panel and the autocomplete component.

capture

Reproducer

No response

PrimeReact version

8.4.0

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to https://www.primefaces.org/primereact/autocomplete/
  2. Focus the AutoComplete component from the "Multiple" example.
  3. Make sure that there's no space on the bottom to show the overlay panel.
  4. Type "a" and wait for the panel to appear.
  5. Type "f" and wait for the options to reload.
  6. You should see a space between the overlay panel and the autocomplete component.

capture

Expected behavior

There should be no space between the overlay panel and the autocomplete component. If the list of options is too large the user can get lost of where to see.

@pascualmj pascualmj added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 10, 2022
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 11, 2022
@melloware
Copy link
Member

Assigning to @mertsincan this is a bug in the DomHandler.alignOverlay method.

@melloware
Copy link
Member

Looks like PrimeVue handles this a little better: https://www.primefaces.org/primevue/autocomplete

@pascualmj
Copy link
Author

Any updates regarding this issue? 😄

@melloware
Copy link
Member

melloware added a commit to melloware/primereact that referenced this issue Dec 5, 2022
@melloware melloware added this to the 8.7.4 milestone Dec 5, 2022
@melloware melloware changed the title AutoComplete component: annoying space between overlay panel and the autocomplete component AutoComplete: space between overlay panel and the component Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants