Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARIA: Standardize close/clear button labels #3280

Closed
melloware opened this issue Sep 10, 2022 · 0 comments · Fixed by #3281
Closed

ARIA: Standardize close/clear button labels #3280

melloware opened this issue Sep 10, 2022 · 0 comments · Fixed by #3281
Assignees
@melloware
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Core Team Issue or pull request has been *opened* by a member of Core Team Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
8.6.0

Comments

@melloware
Copy link
Member

Of all the close and clear buttons in the lib some have Aria Labels but all should fall back to localeOptions('close'); if not set so a button always has a label.
@melloware melloware self-assigned this Sep 10, 2022
@melloware melloware added Component: Accessibility Issue or pull request is related to WCAG or ARIA Core Team Issue or pull request has been *opened* by a member of Core Team labels Sep 10, 2022
@melloware melloware added this to the 8.6.0 milestone Sep 10, 2022
melloware added a commit to melloware/primereact that referenced this issue Sep 10, 2022
@melloware
Fix primefaces#3280: ARIA add close/clear labels
3cf2e39
@melloware melloware mentioned this issue Sep 10, 2022
Merged
melloware added a commit that referenced this issue Sep 10, 2022
@melloware
Fix #3280: ARIA add close/clear labels (#3281)
8507fd1
@mertsincan mertsincan added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Sep 22, 2022
@kbeeveer46 kbeeveer46 mentioned this issue Sep 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Core Team Issue or pull request has been *opened* by a member of Core Team Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
8.6.0
Development

Successfully merging a pull request may close this issue.

Fix #3280: ARIA add close/clear labels melloware/primereact
2 participants
@melloware @mertsincan