-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TabView: allow aria-label attribute for scrollable buttons #3259
Comments
In fact, there are many buttons (or divs with the attribute role='button' or form element), which are generated by components, that do not have an 'aria-label' attribute.
All these small elements generate accessibility errors. I know that the accessibility part of PrimeReact is under development and that there is a lot of work to do and things to think about. But I just wanted to know if you are aware of these small defects. |
Yep I have seen these myself when I run Lighthouse on my app. |
OK here is what I did in my PR. I reuse the same ARIA labels from PrimeLocale that I use in Paginator buttons. See: https://github.com/primefaces/primelocale/blob/main/en.json Locale: https://primefaces.org/primereact/locale/ I am using the "aria": {
"trueLabel": "True",
"falseLabel": "False",
"nullLabel": "Not Selected",
"pageLabel": "Page",
"firstPageLabel": "First Page",
"lastPageLabel": "Last Page",
"nextPageLabel": "Next Page",
"previousPageLabel": "Previous Page"
} |
@kyybo Can you open separate issue for Datatable Aria label I will fix those too. |
@melloware Alright I'll do it. Thank you ! |
Describe the feature you would like to see added
Hello !
Is it possible to allow the aria-label attribute on the buttons (previous and next) on each side of the tab headers when you have a scrollable TabView? These generated buttons don't seem to be customizable.
Is your feature request related to a problem?
No response
Describe the solution you'd like
Maybe we could have a scrollableOptions attribute for the TabView component and the properties of these buttons would be used as an object in it (a bit like the virtualScrollerOptions attribute in the DataTable component).
Describe alternatives you have considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: