-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialog: Focus trap issue with multiple dialogs #3256
Comments
melloware
added a commit
to melloware/primereact
that referenced
this issue
Sep 7, 2022
Great test case! Got to the bottom of it. |
melloware
added a commit
to melloware/primereact
that referenced
this issue
Sep 8, 2022
melloware
added a commit
that referenced
this issue
Sep 8, 2022
melloware
added a commit
to melloware/primereact
that referenced
this issue
Oct 31, 2022
melloware
added a commit
to melloware/primereact
that referenced
this issue
Oct 31, 2022
melloware
added a commit
that referenced
this issue
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
If 2 Dialog components are open at once (one brought up from a button in the first Dialog) and the prop
closable={false}
is on the nested Dialog, tab button navigation fails to focus on the fields of the nested Dialog, instead preferring fields in the parent Dialog component. Not having propclosable={false}
allows tab navigation of the fields in the nested Dialog.Reproducer
https://codesandbox.io/s/primereact-dialog-tab-issue-9uw81h?file=/src/index.js
PrimeReact version
8.4.0
React version
18.x
Language
ALL
Build / Runtime
Create React App (CRA)
Browser(s)
Chrome 104
Steps to reproduce the behavior
In the provided CodeSandbox:
closable={false}
).closable={false}
).Expected behavior
Tab navigation should work on nested Dialog components where the prop
closable={false}
has been passed.The text was updated successfully, but these errors were encountered: