Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rating: Add icon templates #3219

Closed
4 tasks done
mertsincan opened this issue Sep 1, 2022 · 0 comments · Fixed by #3248
Closed
4 tasks done

Rating: Add icon templates #3219

mertsincan opened this issue Sep 1, 2022 · 0 comments · Fixed by #3248
Assignees
@ulasturann @habubey
Labels
Core Team Issue or pull request has been *opened* by a member of Core Team Type: New Feature Issue contains a new feature or new component request
Milestone
8.5.0

Comments

@mertsincan
Copy link
Member

mertsincan commented Sep 1, 2022 •
edited
Loading

Added the following props to customize icons;

  • onIcon
  • offIcon
  • onIconProps
  • offIconProps
@mertsincan mertsincan added Type: New Feature Issue contains a new feature or new component request Core Team Issue or pull request has been *opened* by a member of Core Team labels Sep 1, 2022
@mertsincan mertsincan added this to the 8.5.0 milestone Sep 1, 2022
@mertsincan mertsincan linked a pull request Sep 1, 2022 that will close this issue
Fixed #3219 - Rating Component with custom icons #3216
Closed
@melloware melloware changed the title Add icon templates to Rating Rating: Add icon templates Sep 3, 2022
@mertsincan mertsincan modified the milestones: 8.5.0, 9.0.0 Sep 6, 2022
@ulasturann ulasturann linked a pull request Sep 6, 2022 that will close this issue
Fixed #3219 - Rating Component with custom icons. #3248
Merged
mertsincan pushed a commit that referenced this issue Sep 7, 2022
@ulasturann
Fixed #3219 - Rating Component with custom icons. (#3248)
cc28c50 
* feat: add new attributes to rating component.(onIcon, offIcon, onIconProps, offIconProps, cancelIcon, cancelIconProps).
fix: wrong value on the rating docs.
fix: typo on the rating demo page.

* build: add missing attributes on the api generator/rating.

* fix: typo on Rating Demo page.

Co-authored-by: Ulaş Turan <[email protected]>
@mertsincan mertsincan modified the milestones: 9.0.0, 8.5.0 Sep 7, 2022
mertsincan added a commit that referenced this issue Sep 7, 2022
@mertsincan
Refactor #3219 - Rating: Add icon templates
69e7fed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ulasturann ulasturann

@habubey habubey

Labels
Core Team Issue or pull request has been *opened* by a member of Core Team Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Milestone
8.5.0
3 participants
@mertsincan @ulasturann @habubey