Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog: Responsive breakpoints no longer working #3184

Closed
melloware opened this issue Aug 25, 2022 · 3 comments · Fixed by #3185
Closed

Dialog: Responsive breakpoints no longer working #3184

melloware opened this issue Aug 25, 2022 · 3 comments · Fixed by #3185
Assignees
@melloware
Labels
Core Team Issue or pull request has been *opened* by a member of Core Team Type: Bug Issue contains a defect related to a specific component.
Milestone
8.5.0

Comments

@melloware
Copy link
Member

Describe the bug

The responsive breakpoints are no longer working you can see in the showcase: https://primefaces.org/primereact/dialog/

Reproducer

https://primefaces.org/primereact/dialog/

PrimeReact version

8.4.0

React version

18.x

Language

ALL

Build / Runtime

Next.js

Browser(s)

ALL

Steps to reproduce the behavior

In the showcase resize the browser small and notice the 100vw does not get implemented.

Expected behavior

The responsive breakpoints work as they did before.
@melloware melloware added Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 25, 2022
melloware added a commit to melloware/primereact that referenced this issue Aug 25, 2022
@melloware
Fix primefaces#3184: Dialog responsive breakpoints restored
a801b95
@melloware melloware mentioned this issue Aug 25, 2022
Merged
@melloware melloware self-assigned this Aug 25, 2022
@melloware melloware added this to the 8.5.0 milestone Aug 25, 2022
@mertsincan mertsincan added the Core Team Issue or pull request has been *opened* by a member of Core Team label Aug 25, 2022
melloware added a commit that referenced this issue Aug 25, 2022
@melloware
Fix #3184: Dialog responsive breakpoints restored (#3185)
dc63ed1
@Douglas-Hsieh
Copy link

This still isn't working and isn't working on the showcase
Screenshot (247)

@melloware
Copy link
Member Author

@Douglas-Hsieh its fixed in an upcoming release with this ticket: #5551

@Douglas-Hsieh
Copy link

@melloware Ah, nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Core Team Issue or pull request has been *opened* by a member of Core Team Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
8.5.0
Development

Successfully merging a pull request may close this issue.

Fix #3184: Dialog responsive breakpoints restored melloware/primereact
3 participants
@melloware @mertsincan @Douglas-Hsieh