Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript Circular Dependency #3143

Closed
melloware opened this issue Aug 7, 2022 · 0 comments · Fixed by #3144
Closed

TypeScript Circular Dependency #3143

melloware opened this issue Aug 7, 2022 · 0 comments · Fixed by #3144
Assignees
@melloware
Labels
Typescript Issue or pull request is *only* related to TypeScript definition
Milestone
8.4.0

Comments

@melloware
Copy link
Member

Introduced with nullsortorder.

components/lib/primereact.all.js → dist/primereact.all.cjs.js, dist/primereact.all.esm.js...
(!) Circular dependency
components/lib/api/Api.js -> components/lib/api/FilterService.js -> components/lib/utils/Utils.js -> components/lib/utils/ObjectUtils.js -> components/lib/api/Api.js
created dist/primereact.all.cjs.js, dist/primereact.all.esm.js in 8.6s

components/lib/primereact.all.js → dist/primereact.all.js...
(!) Circular dependency
components/lib/api/Api.js -> components/lib/api/FilterService.js -> components/lib/utils/Utils.js -> components/lib/utils/ObjectUtils.js -> components/lib/api/Api.js
created dist/primereact.all.js in 8.3s

components/lib/primereact.all.js → dist/primereact.all.cjs.min.js, dist/primereact.all.esm.min.js...
(!) Circular dependency
components/lib/api/Api.js -> components/lib/api/FilterService.js -> components/lib/utils/Utils.js -> components/lib/utils/ObjectUtils.js -> components/lib/api/Api.js
created dist/primereact.all.cjs.min.js, dist/primereact.all.esm.min.js in 14.8s

components/lib/primereact.all.js → dist/primereact.all.min.js...
(!) Circular dependency
components/lib/api/Api.js -> components/lib/api/FilterService.js -> components/lib/utils/Utils.js -> components/lib/utils/ObjectUtils.js -> components/lib/api/Api.js
created dist/primereact.all.min.js in 13.1s
@melloware melloware self-assigned this Aug 7, 2022
@melloware melloware added the Type: Bug Issue contains a defect related to a specific component. label Aug 7, 2022
@melloware melloware added this to the 9.0.0 milestone Aug 7, 2022
melloware added a commit to melloware/primereact that referenced this issue Aug 7, 2022
@melloware
Fix primefaces#3143: ObjectUtils circular dependency fix
eca33b0
@melloware melloware mentioned this issue Aug 7, 2022
Merged
@melloware melloware added Typescript Issue or pull request is *only* related to TypeScript definition and removed Type: Bug Issue contains a defect related to a specific component. labels Aug 7, 2022
@mertsincan mertsincan modified the milestones: 9.0.0, 8.4.0 Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Typescript Issue or pull request is *only* related to TypeScript definition
Projects
None yet
Milestone
8.4.0
Development

Successfully merging a pull request may close this issue.

Fix #3143: ObjectUtils circular dependency fix melloware/primereact
2 participants
@melloware @mertsincan