Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to open class source for component: Formik #3124

Closed
gone63 opened this issue Aug 2, 2022 · 4 comments · Fixed by #3165
Closed

Unable to open class source for component: Formik #3124

gone63 opened this issue Aug 2, 2022 · 4 comments · Fixed by #3165
Assignees
Labels
Component: Documentation Issue or pull request is related to Documentation
Milestone

Comments

@gone63
Copy link

gone63 commented Aug 2, 2022

Describe the bug

When we open up documentation for the Formik component, we can check out a few examples using hooks, classes, TS and Browser Source. When we click on class source demo we are able to see console errors and the the window for demo is not opening up.

Reproducer

No response

PrimeReact version

8.0.0

React version

18.x

Language

ALL

Build / Runtime

Create React App (CRA)

Browser(s)

ALL

Steps to reproduce the behavior

  1. Go to link https://www.primefaces.org/primereact/formik/.
  2. Click on class source demo button.
  3. Check the console

Expected behavior

No response

@gone63 gone63 added Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: Bug Issue contains a defect related to a specific component. labels Aug 2, 2022
@melloware
Copy link
Member

melloware commented Aug 2, 2022

I am on the Showcase and I don't see a "Class Source" only Hooks Source and TS Source?

https://www.primefaces.org/primereact/formik/

@melloware melloware added Component: Documentation Issue or pull request is related to Documentation Resolution: Invalid Issue or pull request is not valid in the latest version and removed Type: Bug Issue contains a defect related to a specific component. Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Component: Documentation Issue or pull request is related to Documentation labels Aug 2, 2022
@melloware
Copy link
Member

image

@gone63
Copy link
Author

gone63 commented Aug 18, 2022

@melloware sorry for the delay in responding to your comment. On formik demo page, we have demo action button. When we click on the first button for getting source code, we have an option called Class Source Demo, whenever I am clicking on that button I am not getting redirected to demo code and I am able to see console error too.

You can refer to the screenshot below
Screenshot 2022-08-18 at 6 29 02 PM
:

@melloware melloware reopened this Aug 18, 2022
@melloware
Copy link
Member

Got it! yep i will remove that.

melloware added a commit to melloware/primereact that referenced this issue Aug 18, 2022
@melloware melloware self-assigned this Aug 18, 2022
@melloware melloware added Component: Documentation Issue or pull request is related to Documentation and removed Resolution: Invalid Issue or pull request is not valid in the latest version labels Aug 18, 2022
@melloware melloware added this to the 9.0.0 milestone Aug 18, 2022
melloware added a commit to melloware/primereact that referenced this issue Aug 18, 2022
melloware added a commit to melloware/primereact that referenced this issue Aug 18, 2022
melloware added a commit that referenced this issue Aug 18, 2022
* Fix #3124: Warn if a code sandbox demo is not available

* Fix #3124: Ability to hide certain code sandbox props
@mertsincan mertsincan modified the milestones: 9.0.0, 8.4.0 Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants