Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SplitButton: "loading" and "loadingIcon" #2995

Closed
davidbejarcaceres opened this issue Jun 17, 2022 · 0 comments · Fixed by #3028
Closed

SplitButton: "loading" and "loadingIcon" #2995

davidbejarcaceres opened this issue Jun 17, 2022 · 0 comments · Fixed by #3028
Assignees
@cetincakiroglu
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add

Comments

@davidbejarcaceres
Copy link

Describe the feature you would like to see added

"loading" and "loadingIcon" props, the same as in Button component.

Is your feature request related to a problem?

Will give consistency to the different buttons in Prime

Describe the solution you'd like

Same behavior from Button, props "loading" and "loadingIcon" to show the icon rotating when loading === true.

Describe alternatives you have considered

No response

Additional context

No response
@davidbejarcaceres davidbejarcaceres added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jun 17, 2022
@davidbejarcaceres davidbejarcaceres changed the title Component: SplitButton Component: SplitButton "loading" and "loadingIcon" Jun 17, 2022
@melloware melloware changed the title Component: SplitButton "loading" and "loadingIcon" SplitButton: "loading" and "loadingIcon" Jun 17, 2022
@cetincakiroglu cetincakiroglu self-assigned this Jul 4, 2022
cetincakiroglu added a commit to cetincakiroglu/primereact that referenced this issue Jul 4, 2022
@cetincakiroglu
Fixed primefaces#2995 - SplitButton | Add loading and loadingIcon
7f57924
@cetincakiroglu cetincakiroglu linked a pull request Jul 4, 2022 that will close this issue
Fixed #2995 - SplitButton | Add loading and loadingIcon #3028
Merged
cetincakiroglu added a commit that referenced this issue Jul 5, 2022
@cetincakiroglu
Merge pull request #3028 from cetincakiroglu/issue-2995
7e23116 
Fixed #2995 - SplitButton | Add loading and loadingIcon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cetincakiroglu cetincakiroglu

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed #2995 - SplitButton | Add loading and loadingIcon cetincakiroglu/primereact
2 participants
@davidbejarcaceres @cetincakiroglu