Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Badge/Avatar: update Typescript inheritance #2974

Closed
inad9300 opened this issue Jun 8, 2022 · 3 comments · Fixed by #2975 or #2993
Closed

Badge/Avatar: update Typescript inheritance #2974

inad9300 opened this issue Jun 8, 2022 · 3 comments · Fixed by #2975 or #2993
Assignees
@melloware
Labels
Typescript Issue or pull request is *only* related to TypeScript definition
Milestone
8.2.0

Comments

@inad9300
Copy link
Contributor

inad9300 commented Jun 8, 2022

Describe the feature you would like to see added

It'd be useful to have the "title" HTML global attribute available in the Badge component (and in fact, in all components).

Is your feature request related to a problem?

No response

Describe the solution you'd like

No response

Describe alternatives you have considered

No response

Additional context

No response
@inad9300 inad9300 added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jun 8, 2022
@melloware
Copy link
Member

Hmm when I do this...

<Badge value="2" className="mr-2" title="Test"></Badge>

It appears
image

So I think this is just a TypeScript issue?

@melloware melloware added Typescript Issue or pull request is *only* related to TypeScript definition and removed Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add labels Jun 8, 2022
@melloware melloware changed the title Badge: allow title attribute Badge/Avatar: allow title attribute Jun 8, 2022
melloware added a commit to melloware/primereact that referenced this issue Jun 8, 2022
@melloware
Fix primefaces#2974: Badge/Avatar typescript inheritance
fa3bae7
@melloware melloware mentioned this issue Jun 8, 2022
Merged
@melloware melloware self-assigned this Jun 8, 2022
@melloware melloware added this to the 8.2.0 milestone Jun 8, 2022
@melloware
Copy link
Member

Can you check out my PR?

melloware added a commit that referenced this issue Jun 10, 2022
@melloware
Fix #2974: Badge/Avatar typescript inheritance (#2975)
d838b83
@melloware melloware changed the title Badge/Avatar: allow title attribute Badge/Avatar: update Typescript inheritance Jun 10, 2022
@inad9300
Copy link
Contributor Author

Done!

melloware added a commit to melloware/primereact that referenced this issue Jun 16, 2022
@melloware
Fix primefaces#2974: Badge/Avatar/Card/Chip typescript inheritance
7c0370b
@melloware melloware mentioned this issue Jun 16, 2022
Merged
melloware added a commit that referenced this issue Jun 16, 2022
@melloware
Fix #2974: Badge/Avatar/Card/Chip typescript inheritance (#2993)
46e5ae6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Typescript Issue or pull request is *only* related to TypeScript definition
Projects
None yet
Milestone
8.2.0
2 participants
@inad9300 @melloware