Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable: RowReorder handle displayed when table is not set for reordering #2935

Closed
turco7 opened this issue May 26, 2022 · 3 comments · Fixed by #2938
Closed

DataTable: RowReorder handle displayed when table is not set for reordering #2935

turco7 opened this issue May 26, 2022 · 3 comments · Fixed by #2938
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
8.2.0

Comments

@turco7
Copy link

turco7 commented May 26, 2022

Describe the bug

By holding down on a row of the table and dragging up or down, the ui appears to reorder the table even if it is not defined through "onRowReorder"

Reproducer

No response

PrimeReact version

8.0.1

React version

17.x

Language

ALL

Build / Runtime

Next.js

Browser(s)

Chrome

Steps to reproduce the behavior

  1. holding down on a row of the table
  2. dragging up or down
  3. the reorder ui appears to the table

Expected behavior

No response
@turco7 turco7 added the Type: Bug Issue contains a defect related to a specific component. label May 26, 2022
@melloware
Copy link
Member

Can you prrovide a code sandbox reproducer or point it out on the showcase? I don't know what you mean? Or post your DataTable React snippet?

@melloware melloware changed the title DataTable DataTable: RowReorder May 26, 2022
@melloware melloware added Resolution: Needs More Information More information about the issue is needed to find a correct solution and removed Type: Bug Issue contains a defect related to a specific component. labels May 26, 2022
@turco7
Copy link
Author

turco7 commented May 27, 2022

image

It appears on the documentation. As you can see the dragger is not present but the ui appears anyway to reorder the table.

@melloware
Copy link
Member

melloware commented May 27, 2022 •
edited
Loading

I can't reproduce on the showcase page Datatable Basic. I am using Chrome 101 and when I click and hold and drag nothing happens.

Edit: Nevermind it just happened. I had to click specifically on the line in between rows not on the row itself!

@melloware melloware added Type: Bug Issue contains a defect related to a specific component. confirmed and removed Resolution: Needs More Information More information about the issue is needed to find a correct solution labels May 27, 2022
@melloware melloware changed the title DataTable: RowReorder DataTable: RowReorder handle displayed when table is not set for reordering May 27, 2022
melloware added a commit to melloware/primereact that referenced this issue May 27, 2022
@melloware
Fix primefaces#2935: Datatable do not display handle if not row dragging
c6abc7a
@melloware melloware mentioned this issue May 27, 2022
Merged
@melloware melloware self-assigned this May 27, 2022
@melloware melloware added this to the 8.2.0 milestone May 27, 2022
melloware added a commit that referenced this issue May 27, 2022
@melloware
Fix #2935: Datatable do not display handle if not row dragging (#2938)
8b0257e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
8.2.0
Development

Successfully merging a pull request may close this issue.

Fix #2935: Datatable do not display handle if not row dragging melloware/primereact
2 participants
@melloware @turco7