Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar: onMonthChange is marked as required #2763

Closed
yudatadei opened this issue Apr 18, 2022 · 1 comment · Fixed by #2767
Closed

Calendar: onMonthChange is marked as required #2763

yudatadei opened this issue Apr 18, 2022 · 1 comment · Fixed by #2767
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component. Typescript Issue or pull request is *only* related to TypeScript definition
Milestone
8.0.0.Final

Comments

@yudatadei
Copy link

primereact/components/lib/calendar/Calendar.d.ts

Line 152 in d8e5374

onMonthChange(e: CalendarMonthChangeParams): void

melloware added a commit to melloware/primereact that referenced this issue Apr 18, 2022
@melloware
Fix primefaces#2763: Calendar onMonthChange made optional
0ad0c58
@melloware melloware self-assigned this Apr 18, 2022
@melloware melloware added the Component: Documentation Issue or pull request is related to Documentation label Apr 18, 2022
@melloware melloware added this to the 8.0.0-rc.3 milestone Apr 18, 2022
@melloware melloware mentioned this issue Apr 18, 2022
Merged
@melloware
Copy link
Member

Thank you for reporting!

melloware added a commit that referenced this issue Apr 18, 2022
@melloware
Fix #2763: Calendar onMonthChange made optional (#2767)
37e2d45
@mertsincan mertsincan added Type: Bug Issue contains a defect related to a specific component. and removed Component: Documentation Issue or pull request is related to Documentation labels Apr 20, 2022
@melloware melloware added the Typescript Issue or pull request is *only* related to TypeScript definition label Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component. Typescript Issue or pull request is *only* related to TypeScript definition
Projects
None yet
Milestone
8.0.0.Final
Development

Successfully merging a pull request may close this issue.

Fix #2763: Calendar onMonthChange made optional melloware/primereact
3 participants
@melloware @mertsincan @yudatadei