TypeScript: Improve definitions on all components

[mertsincan]

Ref; https://github.com/primefaces/primevue/blob/master/src/components/accordion/Accordion.d.ts

Notes:

• Attribute 'children' is missing in primereact 8.0.0-rc.1 #2732
• Custom component properties override remove ref #2721

A general study can be made on this subject and help users read the codes better.

[Named-export]

How are the typescript definitions generated? By hand?

[melloware]

How are the typescript definitions generated? By hand?

Yes currently by hand when we make changes in the components we update the TS definition.

[kalinkrustev]

mertsincan added this to the 9.0.0 milestone 5 days ago

Does this mean version 9 will be based on TypeScript? Sounds cool !!!

[melloware]

I am not sure is going to be written in TypeScript just that the definitions get an overhaul and documented similar to how PrimeVue is doing it.

[gordolio]

Honestly, most of the issues that I experience with primereact are related to the type definitions being missing or incorrect. This happens most often with events. I often need to place a breakpoint in an event just to see what arguments are passed in.

IMHO, the lasting fix for this would be to have a typescript-first approach. Change the extensions of all the js source files to be ts, add the noImplicitAny: true option, and let the typescript compiler show what needs to be fixed.

Then future improvements will have a much reduced chance of regression in missing/incorrect type definitions.

[gordolio]

Additional improvements could be made by makingoptions on various components into generics.. options: T[], then definitions like this could be used: optionLabel?: keyof T, optionValue?: keyof T, etc.

[melloware]

@gordolio its easier said than done if you look at this attempt at a PR which worked but we had to roll it back because it was too burdensome: https://github.com/primefaces/primereact/pull/3199/files