Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TabMenu with MenuItem template function does not work properly #2590

Closed
kalinkrustev opened this issue Jan 20, 2022 · 1 comment · Fixed by #2591
Closed

TabMenu with MenuItem template function does not work properly #2590

kalinkrustev opened this issue Jan 20, 2022 · 1 comment · Fixed by #2591
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
7.2.1

Comments

@kalinkrustev
Copy link
Contributor

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Current behavior
When a template function is passed to TabMenu.model item, tabs do not change correctly, because index is not updated.

Expected behavior
Tabs to change correctly.

  • PrimeReact version:
    7.2.0
@kalinkrustev kalinkrustev mentioned this issue Jan 20, 2022
Merged
@melloware
Copy link
Member

Excellent report and PR.

@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Feb 17, 2022
@mertsincan mertsincan added this to the 7.2.1 milestone Feb 17, 2022
mertsincan pushed a commit that referenced this issue Feb 17, 2022
@kalinkrustev
fixed #2590 - itemClick missing index parameter (#2591)
0a65d4c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
7.2.1
Development

Successfully merging a pull request may close this issue.

fix: itemClick missing index parameter kalinkrustev/primereact
3 participants
@kalinkrustev @melloware @mertsincan