-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar dismissible works only if Sidebar is modal #2562
Comments
PR Submitted. |
Also I am going to submit another one because |
I have encountered what seems to be the issue described here. In the following link, you can see how toggling dismissibility doesn't actually immediately toggle it. It is only after closing and reopening the sidebar that the dismissible flag is taken into account (so it's probably related to issue #1065 too). https://codesandbox.io/s/primereact-test-forked-ll7b2p?file=/src/index.js |
@melloware mentioning you in case my message wasn't seen, since this is a closed issue 🙃 |
@inad9300 can you open a new ticket so we can track it. You can reference this issue and include your reproducer. |
@inad9300 I have a fix if you want to open a new ticket. |
There is no guarantee in receiving an immediate response in GitHub Issue Tracker, If you'd like to secure our response, you may consider PrimeReact PRO Support where support is provided within 4 business hours
I'm submitting a ... (check one with "x")
Current behavior
When using
dismissible
prop on the sidebar it only works when the Sidebar has themodal
property.Expected behavior
Using
dismissible
should work without having modal Sidebar as well.PrimeReact version:
7.0.1
Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
Chrome
Language: [all | TypeScript X.X | ES6/7 | ES5]
all
The text was updated successfully, but these errors were encountered: