Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building against primereact 6.4.1 generates TS1036 error against VirtualScroller.d.ts:38 #2123

Closed
pieandcakes opened this issue Jun 17, 2021 · 0 comments · Fixed by #2125
Closed
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@pieandcakes
Copy link
Contributor

pieandcakes commented Jun 17, 2021

There is no guarantee in receiving an immediate response in GitHub Issue Tracker, If you'd like to secure our response, you may consider PrimeReact PRO Support where support is provided within 4 business hours

I'm submitting a ... (check one with "x")

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Codesandbox Case (Bug Reports)
Please fork the codesandbox below and create a case demonstrating your bug report. Issues without a codesandbox have much less possibility to be reviewed.

https://codesandbox.io/s/qjx332qq4

Current behavior

Expected behavior

Minimal reproduction of the problem with instructions

I'm working on updating PrimeReact to 6.4.1 and I see this error when building in Visual Studio 2019:
image

This points to the extra semicolon on line 38 of VirtualScroller.d.ts
image


Please tell us about your environment:

Visual Studio 2019, npm

  • React version:

16.13.0

  • PrimeReact version:

6.4.1

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    typescript 3.8.3, ES5
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Jun 23, 2021
@mertsincan mertsincan added this to the 6.4.2 milestone Jun 23, 2021
@mertsincan mertsincan modified the milestones: 6.5.0, 6.5.0-rc1 Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants