Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect types for CascadeSelectProps and ConfirmDialogProps #1908

Closed
mateusnava opened this issue Mar 26, 2021 · 0 comments · Fixed by #1909
Closed

Incorrect types for CascadeSelectProps and ConfirmDialogProps #1908

mateusnava opened this issue Mar 26, 2021 · 0 comments · Fixed by #1909
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
6.3.0

Comments

@mateusnava
Copy link
Contributor

Incorrect types in ConfirmDialog.d.ts and CascadeSelect.d.ts

[x ] bug report
[ ] feature request
[ ] support request

Current behavior
Type array does not exist <CascadeSelect.d.ts>
Wrong extends in ConfirmDialog.d.ts

Expected behavior
Change to Array<any>
Change to extends Omit<DialogProps, 'onHide'>
@mateusnava mateusnava mentioned this issue Mar 26, 2021
Merged
mertsincan pushed a commit that referenced this issue Apr 8, 2021
@mateusnava
Fixed #1908
e67a12b
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Apr 8, 2021
@mertsincan mertsincan added this to the 6.2.2 milestone Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
6.3.0
Development

Successfully merging a pull request may close this issue.

Fix some types
2 participants
@mateusnava @mertsincan