Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add browser event param to editor callbacks on Datatable #1577

Closed
TonisPiip opened this issue Sep 12, 2020 · 1 comment
Closed

Add browser event param to editor callbacks on Datatable #1577

TonisPiip opened this issue Sep 12, 2020 · 1 comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@TonisPiip
Copy link
Contributor

I'm submitting a ... (check one with "x")

[ ] bug report
[X] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Current behavior
onEditorSubmit, onEditorOpen, onEditorCancel is called with only the cellProps.

Expected behavior
onEditorSubmit, onEditorOpen, onEditorCancel called with cellprops, event and possiblly 'this' as params.

I have some logic that if the user open the editor of a CheckBox field with a click, as opposed to by keyboard navigation with tab or Enter. The editing value is toggled, so that the user doesn't need to click twice. To toggle a checkbox in a grid.

Currently I've been using my fork of this repo. And I have it so onEditorOpen/Cancel/Submit get given 'this ' as well as 'event.

I'm wanting to 'get off' my fork and back onto the master branch of the NPM version. however this is one thing I'm not seeing an alternative solution.

If I submit a PR might it get accepted? I was the one who actually originally submitted this callbacks originally as a PR.
#892

I'm OK with the arguments being in this order (Cellprops, event, this) or whatever would be accepted.

TonisPiip added a commit to lino-framework/primereact that referenced this issue Sep 14, 2020
@mertsincan mertsincan changed the title adding Event to Datatable.onEditor callbacks. Add browser event param to editor callbacks on Datatable Nov 29, 2020
@mertsincan mertsincan added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Nov 29, 2020
@mertsincan mertsincan added this to the 5.0.2 milestone Nov 29, 2020
@mertsincan
Copy link
Member

Also, please see this enhancement; #1692

Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants