-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FileUpload: Disable buttons while uploading #1525
Labels
Type: Enhancement
Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
Comments
mertsincan
added a commit
that referenced
this issue
Sep 10, 2020
Fixed #1525 - incorrect behavior during file upload
mertsincan
added
the
Type: Bug
Issue contains a defect related to a specific component.
label
Sep 10, 2020
mertsincan
removed
the
Type: Bug
Issue contains a defect related to a specific component.
label
Sep 10, 2020
mertsincan
added a commit
that referenced
this issue
Sep 10, 2020
mertsincan
added a commit
that referenced
this issue
Sep 10, 2020
Revert "Fix incorrect behavior during file upload - #1525"
mertsincan
added
the
Status: Discussion
Issue or pull request needs to be discussed by Core Team
label
Sep 10, 2020
Is there anything I can do to help you with this isuue? |
melloware
changed the title
Incorrect behavior during file upload
FileUpload: Disable buttons while uploading
Apr 22, 2022
melloware
added a commit
to melloware/primereact
that referenced
this issue
Apr 29, 2022
mertsincan
pushed a commit
that referenced
this issue
May 9, 2022
mertsincan
added
Type: Enhancement
Issue contains an enhancement related to a specific component. Additional functionality has been add
and removed
Status: Discussion
Issue or pull request needs to be discussed by Core Team
labels
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Type: Enhancement
Issue contains an enhancement related to a specific component. Additional functionality has been add
[x] bug report
Problem
Parallel upload is not considered, but it can be operated during upload. Therefore, the following problems occur.
If you upload while uploading, the files to be uploaded are uploaded in duplicate.
Reproduction procedure
Click the upload button many times during the upload.
The progress bar will be displayed more or less as the progress of multiple uploads is received in one state.
Reproduction procedure (Advanced mode only)
You can easily check by uploading large files in succession.
When selecting a file during upload, the files parameter of onUpload(), onError() may be different from the file that was actually uploaded or failed to upload.
Defect Fixes
The current implementation only supports a single upload, so operations during upload are disabled.
Supplement
If the auto property is true, uploading will start after file selection, so disable file selection during uploading.
The files selected during upload are reset after the upload is complete, so the file selection feature during upload is useless.
Since the function of the cancel button is to reset the selected state of the file and it is useless during uploading, the cancel button during uploading is disabled.
You may confuse that you can cancel the upload if the Cancel button is enabled during the upload.
The text was updated successfully, but these errors were encountered: