Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable/TreeTable: global filter customization #1450

Closed
VsevolodGolovanov opened this issue Jul 13, 2020 · 1 comment · Fixed by #3400
Closed

DataTable/TreeTable: global filter customization #1450

VsevolodGolovanov opened this issue Jul 13, 2020 · 1 comment · Fixed by #3400
Assignees
@melloware
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone
8.7.0

Comments

@VsevolodGolovanov
Copy link

I'm submitting a ... (check one with "x")

[ ] bug report
[x] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Codesandbox Case (Bug Reports)

Current behavior
Global filter is hardcoded to contains.

Expected behavior
Global filter's behavior should be customizable, probably with new properties globalFilterMatchMode and globalFilterFunction.
Maybe globalFilterMatchMode could have a special mode for reusing the per-field filterMatchMode and filterFunction settings.
Maybe globalFilterFunction could accept additional arguments like field name.

Minimal reproduction of the problem with instructions

Please tell us about your environment:

  • React version:

  • PrimeReact version:
    4.2.2

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
@mertsincan mertsincan added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Feb 10, 2021
@mertsincan mertsincan added this to the 6.1.0 milestone Feb 10, 2021
@mertsincan mertsincan modified the milestones: 6.1.0, 7.0.0 Mar 9, 2021
@mertsincan mertsincan modified the milestones: 8.2.0, Future Jul 6, 2022
@melloware melloware self-assigned this Sep 30, 2022
melloware added a commit to melloware/primereact that referenced this issue Oct 1, 2022
@melloware
Fix primefaces#1450: Datatable/Treetable add globalFilterMatchMode
de87140
@melloware melloware mentioned this issue Oct 1, 2022
Merged
@melloware melloware modified the milestones: Future, 8.6.2 Oct 1, 2022
@melloware
Copy link
Member

For now just added globalFilterMatchMode to both TreeTable and DataTable defaulting to FilterMatchMode.CONTAINS

melloware added a commit that referenced this issue Oct 1, 2022
@melloware
Fix #1450: Datatable/Treetable add globalFilterMatchMode (#3400)
30d72f1
@mertsincan mertsincan added Type: New Feature Issue contains a new feature or new component request and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Milestone
8.7.0
Development

Successfully merging a pull request may close this issue.

Fix #1450: Datatable/Treetable add globalFilterMatchMode melloware/primereact
3 participants
@melloware @VsevolodGolovanov @mertsincan