Fix #3122: Prevent overlay flickering

primefaces · Nov 25, 2022 · d9ec29c · d9ec29c
1 parent 3fa91b3
commit d9ec29c
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 1 deletion.
diff --git a/components/lib/dialog/Dialog.css b/components/lib/dialog/Dialog.css
@@ -29,6 +29,11 @@
     position: relative;
 }
 
+/* Github #3122: Prevent animation flickering */
+.p-dialog:not([class*='p-dialog-']) {
+    display: none;
+}
+
 .p-dialog-content {
     overflow-y: auto;
     flex-grow: 1;

diff --git a/components/lib/dialog/Dialog.js b/components/lib/dialog/Dialog.js
@@ -511,7 +511,8 @@ export const Dialog = React.forwardRef((props, ref) => {
         const otherProps = ObjectUtils.findDiffKeys(props, Dialog.defaultProps);
         const className = classNames('p-dialog p-component', props.className, {
             'p-dialog-rtl': props.rtl,
-            'p-dialog-maximized': maximized
+            'p-dialog-maximized': maximized,
+            'p-dialog-normal': !maximized
         });
         const maskClassName = classNames(
             'p-dialog-mask',

diff --git a/components/lib/overlaypanel/OverlayPanel.css b/components/lib/overlaypanel/OverlayPanel.css
@@ -3,6 +3,10 @@
     margin-top: 10px;
 }
 
+/* Github #3122: Prevent animation flickering */
+.p-overlaypanel:not([class*='p-overlaypanel-']) {
+    display: none;
+}
 
 .p-overlaypanel-flipped {
     margin-top: 0;

diff --git a/components/lib/sidebar/Sidebar.css b/components/lib/sidebar/Sidebar.css
@@ -28,6 +28,11 @@
     position: relative;
 }
 
+/* Github #3122: Prevent animation flickering */
+.p-sidebar:not([class*="p-sidebar-"]){
+    display: none;
+}
+
 .p-sidebar-content {
     overflow-y: auto;
     flex-grow: 1;