Fix #6000: Improved closeOnEscape handling

primefaces · Feb 19, 2024 · ab9eb6a · ab9eb6a
1 parent 08acd0d
commit ab9eb6a
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/components/lib/hooks/useDisplayOrder.js b/components/lib/hooks/useDisplayOrder.js
@@ -9,21 +9,22 @@ export const useDisplayOrder = (group, isVisible = true) => {
 
     React.useEffect(() => {
         if (isVisible) {
-            if (!(group in groupToDisplayedElements)) {
+            if (!groupToDisplayedElements[group]) {
                 groupToDisplayedElements[group] = [];
             }
 
-            const newDisplayOrder = groupToDisplayedElements[group].length + 1;
+            const newDisplayOrder = groupToDisplayedElements[group].push(uid);
 
-            groupToDisplayedElements[group].push(uid);
             setDisplayOrder(newDisplayOrder);
 
             return () => {
-                delete groupToDisplayedElements[group][newDisplayOrder];
-                const lastOrder = groupToDisplayedElements[group].findLastIndex((el) => el !== undefined);
+                delete groupToDisplayedElements[group][newDisplayOrder - 1];
 
                 // Reduce array length, by removing undefined elements at the end of array:
-                groupToDisplayedElements[group].splice(lastOrder + 1);
+                const lastIndex = groupToDisplayedElements[group].length - 1;
+                const lastOrder = groupToDisplayedElements[group].findLastIndex((el) => el !== undefined);
+
+                if (lastOrder !== lastIndex) groupToDisplayedElements[group].splice(lastOrder + 1);
 
                 setDisplayOrder(undefined);
             };