Fix #2987: Datascroller do not reset first on lazy (#3442)

primefaces · Oct 8, 2022 · 95015b6 · 95015b6
1 parent 6b323ac
commit 95015b6
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 10 deletions.
diff --git a/components/lib/datascroller/DataScroller.js b/components/lib/datascroller/DataScroller.js
@@ -120,7 +120,10 @@ export const DataScroller = React.memo(
             if (props.value) {
                 value.current = props.value;
 
-                first.current = 0;
+                if (!props.lazy) {
+                    first.current = 0;
+                }
+
                 dataToRender.current = [];
                 handleDataChange();
             }

diff --git a/components/lib/datascroller/datascroller.d.ts b/components/lib/datascroller/datascroller.d.ts
@@ -8,19 +8,19 @@ interface DataScrollerLazyLoadParams {
 }
 
 export interface DataScrollerProps extends Omit<React.DetailedHTMLProps<React.HTMLAttributes<HTMLDivElement>, HTMLDivElement>, 'ref'> {
-    value?: any[];
-    rows?: number;
-    inline?: boolean;
-    scrollHeight?: string;
-    loader?: boolean;
     buffer?: number;
-    header?: React.ReactNode;
+    children?: React.ReactNode;
+    emptyMessage?: DataScrollerEmptyMessageType;
     footer?: React.ReactNode;
+    header?: React.ReactNode;
+    inline?: boolean;
     lazy?: boolean;
-    emptyMessage?: DataScrollerEmptyMessageType;
-    onLazyLoad?(e: DataScrollerLazyLoadParams): void;
+    loader?: boolean;
+    rows?: number;
+    scrollHeight?: string;
+    value?: any[];
     itemTemplate?(item: any): React.ReactNode;
-    children?: React.ReactNode;
+    onLazyLoad?(e: DataScrollerLazyLoadParams): void;
 }
 
 export declare class DataScroller extends React.Component<DataScrollerProps, any> {