Fix #6427: Chips respect removable function

primefaces · Apr 20, 2024 · 6eaed5d · 6eaed5d
1 parent 4d4a214
commit 6eaed5d
Showing 1 changed file with 12 additions and 12 deletions.
diff --git a/components/lib/chips/Chips.js b/components/lib/chips/Chips.js
@@ -35,7 +35,7 @@ export const Chips = React.memo(
             }
 
             let values = [...props.value];
-            const removedItem = values.splice(index, 1);
+            const removedItem = values.splice(index, 1)[0];
 
             if (!isRemovable(removedItem, index)) {
                 return;
@@ -319,18 +319,18 @@ export const Chips = React.memo(
         };
 
         const createRemoveIcon = (value, index) => {
-            const iconProps = mergeProps(
-                {
-                    className: cx('removeTokenIcon'),
-                    onClick: (event) => removeItem(event, index),
-                    'aria-hidden': 'true'
-                },
-                ptm('removeTokenIcon')
-            );
-            const icon = props.removeIcon || <TimesCircleIcon {...iconProps} />;
-            const removeIcon = IconUtils.getJSXIcon(icon, { ...iconProps }, { props });
-
             if (!props.disabled && !props.readOnly && isRemovable(value, index)) {
+                const iconProps = mergeProps(
+                    {
+                        className: cx('removeTokenIcon'),
+                        onClick: (event) => removeItem(event, index),
+                        'aria-hidden': 'true'
+                    },
+                    ptm('removeTokenIcon')
+                );
+                const icon = props.removeIcon || <TimesCircleIcon {...iconProps} />;
+                const removeIcon = IconUtils.getJSXIcon(icon, { ...iconProps }, { props });
+
                 return removeIcon;
             }