Skip to content

Commit

Permalink
Fixed #250
Browse files Browse the repository at this point in the history
  • Loading branch information
Çağatay Çivici committed Dec 12, 2017
1 parent b965be4 commit 661853d
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/components/accordion/Accordion.js
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ export class Accordion extends Component {

return (
<div className={tabHeaderClass} style={tab.props.headerStyle} onClick={(event) => this.onTabClick(event, tab, index)}>
<a id={id} aria-controls={ariaControls} role="tab" aria-expanded={selected}>
<a href={'#' + ariaControls} id={id} aria-controls={ariaControls} role="tab" aria-expanded={selected}>
<span className={classNames('fa fa-fw', { 'fa-caret-right': !selected, 'fa-caret-down': selected })}></span>
<span className="ui-accordion-header-text">{tab.props.header}</span>
</a>
Expand Down
2 changes: 1 addition & 1 deletion src/components/fieldset/Fieldset.js
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ export class Fieldset extends Component {
return (
<fieldset id={this.props.id} className={className} style={this.props.style}>
<legend className="ui-fieldset-legend ui-corner-all ui-state-default ui-unselectable-text" onClick={this.toggle}>
<a aria-controls={ariaControls} aria-expanded={!this.state.collapsed} tabIndex={this.props.toggleable ? null : -1}>
<a href={'#' + ariaControls} aria-controls={ariaControls} aria-expanded={!this.state.collapsed} tabIndex={this.props.toggleable ? null : -1}>
{toggleIcon}
<span className="ui-fieldset-legend-text">{this.props.legend}</span>
</a>
Expand Down
2 changes: 1 addition & 1 deletion src/components/panel/Panel.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export class Panel extends Component {
let ariaControls = this.id + '_content';

return (
<a className="ui-panel-titlebar-icon ui-panel-titlebar-toggler ui-corner-all ui-state-default" onClick={this.toggle}
<a href={'#' + ariaControls} className="ui-panel-titlebar-icon ui-panel-titlebar-toggler ui-corner-all ui-state-default" onClick={this.toggle}
id={id} aria-controls={ariaControls} aria-expanded={!this.state.collapsed} role="tab">
<span className={classNames('fa fa-fw', {'fa-plus': this.state.collapsed, 'fa-minus': !this.state.collapsed})}></span>
</a>
Expand Down
2 changes: 1 addition & 1 deletion src/components/tabview/TabView.js
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export class TabView extends Component {

return (
<li className={className} role="tab" style={tab.props.headerStyle}>
<a onClick={(e) => this.onTabHeaderClick(e, tab, index)} id={id} aria-controls={ariaControls} aria-selected={selected} >
<a href={'#' + ariaControls} onClick={(e) => this.onTabHeaderClick(e, tab, index)} id={id} aria-controls={ariaControls} aria-selected={selected} >
{tab.props.leftIcon && <span className={classNames('ui-tabview-left-icon fa', tab.props.leftIcon)}></span>}
<span className="ui-tabview-title">{tab.props.header}</span>
{tab.props.rightIcon && <span className={classNames('ui-tabview-right-icon fa', tab.props.rightIcon)}></span>}
Expand Down

0 comments on commit 661853d

Please sign in to comment.