Fix #3636: Radiobutton fire onChange only if chnaged (#3637)

primefaces · Nov 14, 2022 · 6533552 · 6533552
1 parent ddcf214
commit 6533552
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/components/lib/radiobutton/RadioButton.js b/components/lib/radiobutton/RadioButton.js
@@ -18,7 +18,7 @@ export const RadioButton = React.memo(
                 const radioClicked = e.target instanceof HTMLDivElement;
                 const inputClicked = e.target === inputRef.current;
                 const isInputToggled = inputClicked && e.target.checked !== checked;
-                const isRadioToggled = radioClicked && !e.target.checked;
+                const isRadioToggled = radioClicked && (DomHandler.hasClass(elementRef.current, 'p-radiobutton-checked') === checked ? !checked : false);
 
                 if (isInputToggled || isRadioToggled) {
                     const value = !checked;
@@ -37,6 +37,10 @@ export const RadioButton = React.memo(
                             checked: value
                         }
                     });
+
+                    if (isRadioToggled) {
+                        inputRef.current.checked = value;
+                    }
                 }
 
                 DomHandler.focus(inputRef.current);