Fix #2668/#2925: Messages/Toast replace method (#2932)

primefaces · May 25, 2022 · 4b17eb7 · 4b17eb7
1 parent 6f510ab
commit 4b17eb7
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 12 deletions.
diff --git a/components/doc/toast/index.js b/components/doc/toast/index.js
@@ -711,7 +711,16 @@ toast.current.show({life: 5000, severity: 'error', summary: 'Error Message', det
 
 <CodeHighlight>
 {`
-    toast.current.clear();
+toast.current.clear();
+`}
+</CodeHighlight>
+
+                    <h5>Replacing Messages</h5>
+                    <p><i>replace(newMessages)</i> method adds new messages after removing all old messages.</p>
+
+<CodeHighlight lang="js">
+{`
+toast.current.replace(newMessages);
 `}
 </CodeHighlight>
 

diff --git a/components/lib/messages/Messages.js b/components/lib/messages/Messages.js
@@ -11,7 +11,7 @@ export const Messages = React.memo(React.forwardRef((props, ref) => {
 
     const show = (value) => {
         if (value) {
-            let messages = [];
+            let messages;
 
             if (Array.isArray(value)) {
                 for (let i = 0; i < value.length; i++) {
@@ -33,7 +33,8 @@ export const Messages = React.memo(React.forwardRef((props, ref) => {
     }
 
     const replace = (value) => {
-        setMessagesState(value);
+        const replaced = Array.isArray(value) ? value : [value];
+        setMessagesState(replaced);
     }
 
     const onClose = (message) => {

diff --git a/components/lib/toast/Toast.d.ts b/components/lib/toast/Toast.d.ts
@@ -41,4 +41,5 @@ export interface ToastProps {
 export declare class Toast extends React.Component<ToastProps, any> {
     public show(message: ToastMessageType): void;
     public clear(): void;
+    public replace(message: ToastMessageType): void;
 }
diff --git a/components/lib/toast/Toast.js b/components/lib/toast/Toast.js
@@ -18,18 +18,14 @@ export const Toast = React.memo(React.forwardRef((props, ref) => {
             let messages;
 
             if (Array.isArray(value)) {
-                const currentMessages = [...value];
-                for (let i = 0; i < currentMessages.length; i++) {
-                    const message = { ...currentMessages[i] };
-                    message.id = messageIdx++;
-                    currentMessages[i] = message;
+                for (let i = 0; i < value.length; i++) {
+                    value[i].id = messageIdx++;
+                    messages = [...messagesState, ...value];
                 }
-                messages = [...messagesState, ...currentMessages];
             }
             else {
-                const currentMessage = { ...value };
-                currentMessage.id = messageIdx++;
-                messages = messagesState ? [...messagesState, currentMessage] : [currentMessage];
+                value.id = messageIdx++;
+                messages = messagesState ? [...messagesState, value] : [value];
             }
 
             messagesState.length === 0 && ZIndexUtils.set('toast', containerRef.current, PrimeReact.autoZIndex, props.baseZIndex || PrimeReact.zIndex['toast']);
@@ -43,6 +39,11 @@ export const Toast = React.memo(React.forwardRef((props, ref) => {
         setMessagesState([]);
     }
 
+    const replace = (value) => {
+        const replaced = Array.isArray(value) ? value : [value];
+        setMessagesState(replaced);
+    }
+
     const onClose = (message) => {
         const messages = messagesState.filter(msg => msg.id !== message.id);
         setMessagesState(messages);
@@ -66,6 +67,7 @@ export const Toast = React.memo(React.forwardRef((props, ref) => {
 
     React.useImperativeHandle(ref, () => ({
         show,
+        replace,
         clear
     }));