Fixed #341

primefaces · Mar 14, 2018 · 45380f8 · 45380f8
1 parent 59e5931
commit 45380f8
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 3 deletions.
diff --git a/src/components/datatable/BodyRow.js b/src/components/datatable/BodyRow.js
@@ -115,7 +115,7 @@ export class BodyRow extends Component {
         }
 
         return (
-            <tr ref={(el) => {this.container = el;}} className={className} onClick={this.onClick} onTouchEnd={this.onTouchEnd} onContextMenu={this.onRightClick} onMouseDown={this.onMouseDown}
+            <tr ref={(el) => {this.container = el;}} className={className} onClick={this.onClick} onDoubleClick={this.props.onDoubleClick} onTouchEnd={this.onTouchEnd} onContextMenu={this.onRightClick} onMouseDown={this.onMouseDown}
                 onDragStart={this.props.onDragStart} onDragEnd={this.onDragEnd} onDragOver={this.onDragOver} onDragLeave={this.onDragLeave} onDrop={this.onDrop}>
                 {cells}
             </tr>

diff --git a/src/components/datatable/DataTable.d.ts b/src/components/datatable/DataTable.d.ts
@@ -74,6 +74,7 @@ interface DataTableProps {
     onFilter?(filters: Array<any>): void;
     onLazyLoad?(event: DataTableLazyLoadEvent): void;
     onRowClick?(e: {originalEvent: Event, data: any, index: number}): void;
+    onRowDoubleClick?(e: Event): void;
     onRowSelect?(e: {originalEvent: Event, data: any, index: number}): void;
     onRowUnselect?(e: {originalEvent: Event, data: any, index: number}): void;
     onRowExpand?(e: {originalEvent: Event, data: any}): void;

diff --git a/src/components/datatable/DataTable.js b/src/components/datatable/DataTable.js
@@ -79,6 +79,7 @@ export class DataTable extends Component {
         onFilter: null,
         onLazyLoad: null,
         onRowClick: null,
+        onRowDoubleClick: null,
         onRowSelect: null,
         onRowUnselect: null,
         onRowExpand: null,
@@ -156,6 +157,7 @@ export class DataTable extends Component {
         onFilter: PropTypes.func,
         onLazyLoad: PropTypes.func,
         onRowClick: PropTypes.func,
+        onRowDoubleClick: PropTypes.func,
         onRowSelect: PropTypes.func,
         onRowUnselect: PropTypes.func,
         onRowExpand: PropTypes.func,
@@ -826,7 +828,7 @@ export class DataTable extends Component {
     createTableBody(value, columns) {
         return <TableBody value={value} first={this.state.first} rows={this.state.rows} lazy={this.props.lazy} dataKey={this.props.dataKey} compareSelectionBy={this.props.compareSelectionBy}
                         selectionMode={this.props.selectionMode} selection={this.props.selection} metaKeySelection={this.props.metaKeySelection}
-                        onSelectionChange={this.props.onSelectionChange} onRowClick={this.props.onRowClick} onRowSelect={this.props.onRowSelect} onRowUnselect={this.props.onRowUnselect}
+                        onSelectionChange={this.props.onSelectionChange} onRowClick={this.props.onRowClick} onRowDoubleClick={this.props.onRowDoubleClick} onRowSelect={this.props.onRowSelect} onRowUnselect={this.props.onRowUnselect}
                         expandedRows={this.props.expandedRows} onRowToggle={this.props.onRowToggle} rowExpansionTemplate={this.props.rowExpansionTemplate}
                         onRowExpand={this.props.onRowExpand} responsive={this.props.responsive} emptyMessage={this.props.emptyMessage} 
                         contextMenu={this.props.contextMenu} onContextMenuSelect={this.props.onContextMenuSelect} virtualScroll={this.props.virtualScroll}

diff --git a/src/components/datatable/TableBody.js b/src/components/datatable/TableBody.js
@@ -435,7 +435,7 @@ export class TableBody extends Component {
                 }
 
                 //row content
-                let bodyRow = <BodyRow key={i} rowData={rowData} rowIndex={i} onClick={this.onRowClick} onRightClick={this.onRowRightClick} onTouchEnd={this.onRowTouchEnd} 
+                let bodyRow = <BodyRow key={i} rowData={rowData} rowIndex={i} onClick={this.onRowClick} onDoubleClick={this.props.onRowDoubleClick} onRightClick={this.onRowRightClick} onTouchEnd={this.onRowTouchEnd} 
                             onRowToggle={this.onRowToggle} expanded={expanded} responsive={this.props.responsive}
                             onRadioClick={this.onRadioClick} onCheckboxClick={this.onCheckboxClick} selected={selected} rowClassName={this.props.rowClassName}
                             sortField={this.props.sortField} rowGroupMode={this.props.rowGroupMode} groupRowSpan={groupRowSpan}

diff --git a/src/showcase/datatable/DataTableDemo.js b/src/showcase/datatable/DataTableDemo.js
@@ -1870,6 +1870,11 @@ export class DataTableLazyDemo extends Component {
                             <td>event: Browser row click event</td>
                             <td>Callback to invoke when a row is clicked.</td>
                         </tr>
+                        <tr>
+                            <td>onRowDloubleClick</td>
+                            <td>event: Browser double click event</td>
+                            <td>Callback to invoke when a row is double clicked.</td>
+                        </tr>
                         <tr>
                             <td>onRowSelect</td>
                             <td>event.originalEvent: Original event instance. <br />