Skip to content

Commit

Permalink
Fix #4170: Unexpected component hide
Browse files Browse the repository at this point in the history
  • Loading branch information
ulasturann committed Mar 22, 2023
1 parent 3191fd5 commit 4331d6e
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 22 deletions.
15 changes: 5 additions & 10 deletions components/lib/dialog/Dialog.css
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,6 @@
position: relative;
}

/* Github #3122: Prevent animation flickering */
.p-dialog:not([class*='p-dialog-']) {
display: none;
}

.p-dialog-content {
overflow-y: auto;
flex-grow: 1;
Expand Down Expand Up @@ -93,7 +88,7 @@
.p-dialog-exit-active {
opacity: 0;
transform: scale(0.7);
transition: all 150ms cubic-bezier(0.4, 0.0, 0.2, 1);
transition: all 150ms cubic-bezier(0.4, 0, 0.2, 1);
}

/* Top, Bottom, Left, Right, Top* and Bottom* */
Expand All @@ -105,11 +100,11 @@
.p-dialog-top-right .p-dialog,
.p-dialog-bottom-left .p-dialog,
.p-dialog-bottom-right .p-dialog {
margin: .75em;
margin: 0.75em;
}

.p-dialog-top .p-dialog-enter,
.p-dialog-top .p-dialog-exit-active {
.p-dialog-top .p-dialog-exit-active {
transform: translate3d(0px, -100%, 0px);
}

Expand Down Expand Up @@ -145,7 +140,7 @@
.p-dialog-top-right .p-dialog-enter-active,
.p-dialog-bottom-right .p-dialog-enter-active {
transform: translate3d(0px, 0px, 0px);
transition: all .3s ease-out;
transition: all 0.3s ease-out;
}

.p-dialog-top .p-dialog-exit-active,
Expand All @@ -156,7 +151,7 @@
.p-dialog-right .p-dialog-exit-active,
.p-dialog-top-right .p-dialog-exit-active,
.p-dialog-bottom-right .p-dialog-exit-active {
transition: all .3s ease-out;
transition: all 0.3s ease-out;
}

/* Maximize */
Expand Down
15 changes: 5 additions & 10 deletions components/lib/sidebar/Sidebar.css
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,6 @@
position: relative;
}

/* Github #3122: Prevent animation flickering */
.p-sidebar:not([class*="p-sidebar-"]){
display: none;
}

.p-sidebar-content {
overflow-y: auto;
flex-grow: 1;
Expand Down Expand Up @@ -66,7 +61,7 @@
/* Animation */
/* Top, Bottom, Left and Right */
.p-sidebar-top .p-sidebar-enter,
.p-sidebar-top .p-sidebar-exit-active {
.p-sidebar-top .p-sidebar-exit-active {
transform: translate3d(0px, -100%, 0px);
}

Expand All @@ -90,7 +85,7 @@
.p-sidebar-left .p-sidebar-enter-active,
.p-sidebar-right .p-sidebar-enter-active {
transform: translate3d(0px, 0px, 0px);
transition: all .3s;
transition: all 0.3s;
}

.p-sidebar-top .p-sidebar-enter-done,
Expand All @@ -104,7 +99,7 @@
.p-sidebar-bottom .p-sidebar-exit-active,
.p-sidebar-left .p-sidebar-exit-active,
.p-sidebar-right .p-sidebar-exit-active {
transition: all .3s;
transition: all 0.3s;
}

/* Full */
Expand All @@ -116,7 +111,7 @@
.p-sidebar-full .p-sidebar-enter-active {
opacity: 1;
transform: scale(1);
transition: all .15s cubic-bezier(0, 0, 0.2, 1);
transition: all 0.15s cubic-bezier(0, 0, 0.2, 1);
}

.p-sidebar-full .p-sidebar-enter-done {
Expand All @@ -126,7 +121,7 @@
.p-sidebar-full .p-sidebar-exit-active {
opacity: 0;
transform: scale(0.5);
transition: all .15s cubic-bezier(0.4, 0.0, 0.2, 1);
transition: all 0.15s cubic-bezier(0.4, 0, 0.2, 1);
}

/* Position */
Expand Down
4 changes: 2 additions & 2 deletions pages/landing/userssection.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const UsersSection = (props) => {
</div>
</div>
<div aria-hidden="true" className="marquee ">
<div className=" w-full">
<div className=" w-full">
<img src={`https://primefaces.org/cdn/primereact/images/landing-new/whouses/fox-${colorScheme}.svg`} alt={'fox-${colorScheme}'} />
</div>
<div className=" w-full">
Expand All @@ -58,7 +58,7 @@ const UsersSection = (props) => {
</div>
</div>
<div aria-hidden="true" className="marquee ">
<div className=" w-full">
<div className=" w-full">
<img src={`https://primefaces.org/cdn/primereact/images/landing-new/whouses/fox-${colorScheme}.svg`} alt={'fox-${colorScheme}'} />
</div>
<div className=" w-full">
Expand Down

0 comments on commit 4331d6e

Please sign in to comment.