Fix - #5271 sidebar fullscreen unnecessary class assignments fix (#5272)

* updated fullscreen class assignments and removed unused func * lint * removed unnecessary importants
primefaces · Nov 10, 2023 · 00629a0 · 00629a0
1 parent 765d030
commit 00629a0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 12 deletions.
diff --git a/components/lib/sidebar/Sidebar.js b/components/lib/sidebar/Sidebar.js
@@ -53,13 +53,6 @@ export const Sidebar = React.forwardRef((inProps, ref) => {
         return sidebarRef && sidebarRef.current && !sidebarRef.current.contains(event.target);
     };
 
-    const getPositionClass = () => {
-        const positions = ['left', 'right', 'top', 'bottom'];
-        const pos = positions.find((item) => item === props.position);
-
-        return pos ? `p-sidebar-${pos}` : '';
-    };
-
     const focus = () => {
         const activeElement = document.activeElement;
         const isActiveElementInDialog = activeElement && sidebarRef && sidebarRef.current.contains(activeElement);

diff --git a/components/lib/sidebar/SidebarBase.js b/components/lib/sidebar/SidebarBase.js
@@ -11,7 +11,7 @@ const classes = {
 
         return classNames(
             'p-sidebar-mask',
-            pos ? `p-sidebar-${pos}` : '',
+            pos && !props.fullScreen ? `p-sidebar-${pos}` : '',
             {
                 'p-component-overlay p-component-overlay-enter': props.modal,
                 'p-sidebar-mask-scrollblocker': props.blockScroll,
@@ -94,11 +94,11 @@ const styles = `
     .p-sidebar-full .p-sidebar {
         transition: none;
         transform: none;
-        width: 100vw !important;
-        height: 100vh !important;
+        width: 100vw;
+        height: 100vh;
         max-height: 100%;
-        top: 0px !important;
-        left: 0px !important;
+        top: 0px;
+        left: 0px;
     }
     
     /* Animation */