-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fullTemplateTypeCheck issue in TabView #5469
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cagataycivici
added
the
Type: Bug
Issue contains a bug related to a specific component. Something about the component is not working
label
Apr 25, 2018
Merged manually |
ldauvilaire
added a commit
to ldauvilaire/primeng
that referenced
this pull request
Jun 16, 2018
* Fixed primefaces#5577 * Fixed primefaces#5168 * Fixed primefaces#5270 * Fixed primefaces#5184 * Fixed primefaces#5200 * Fixed primefaces#5274 * Fixed invalid closing tags in table docs example * Fixed primefaces#5250 * Fixed primefaces#5121 * Refactor on ScrollPanel demo Fixed primefaces#5532 * Fixed primefaces#5124 * Fixed primefaces#5196 * Fixed primefaces#5207 * Fixed primefaces#5174 * Fixed primefaces#5282 * Fixed primefaces#5211 * Docs for multiselect change detection * Fixed primefaces#5218 * Fixed primefaces#5169 * Fixed primefaces#5167 * Fixed primefaces#5144 * Fixed #primefaces#5158 * Fixed primefaces#5148 * Fixed primefaces#5123 * set class ui-state-disabled when component is disabled * Fixed primefaces#5131 * [Fix primefaces#5598] Disable component-class-suffix rule. As Component suffix is never used in component classes in the whole project, we expect this rule disabled in tslint. * [Fix primefaces#5598] ignore no-inferrable-types rule on class properties. As all class properties are typed, even the obvious ones (e.g: inline: boolean = false;) And those can be considered as documentation for an open-source project, Then we should ignore this rule on class components. * fix trailing comma * Fixed primefaces#5159 * Replaced plunkr with stackblitz * Fixed primefaces#5102 * Fixed primefaces#5193 * Fixed primefaces#5469 * Fixed primefaces#5632 * Refactor primefaces#5549 * Fixed primefaces#5633 * Version update * Fix demo * Fixed primefaces#5634 * Fixed primefaces#5503 * Fixed demo source display * Add doc for hideDelay * Use setTimeout within runOutsideAngular * Fixed primefaces#5499 * Fixed primefaces#5637 * Set version * AOT fixes * New iteration * Version at footer * Fixed primefaces#5656 * Demo fix * Fix table component only applying the last filter before timeout (primefaces#5660) * Fixed primefaces#5664 * Update text * Update text * Delete ng-conf2018 section * Fixed primefaces#5672 * Fixed primefaces#5673 * Add ui-multiselect-open class to ui-multiselect and typo fix for multiselect documentation * Fixed 5687 * Fixed primefaces#5693 * Fixed primefaces#5697 * Fixed primefaces#5699 * Fixed primefaces#5702 * Add style classes for icons * Set version * Fix AOT issue * New version * Fixed quote * Add Harmony * Doc update * Fixed primefaces#5731 * Fixed primefaces#5705 * Names for icons * Fixed primefaces#4409 * Add designer to homepage * Firefox button fix * Fixed primefaces#5664 * Fixed primefaces#5729 * Fixed primefaces#5744 * Set version * Change the position of } * Fixed #primefaces#5758 * Polyfill update * Demo cosmetics to add margins since Angular 6 has preserveWhiteSpace as false by default now * Ignore angular.json * Set version * New dev iteration * Version * Change logo * Change favicon * Change logo * Fix URL * Syntax Error Interface syntax Error double curly braces {{ }} * Fixed primefaces#5772 * Initiated new TreeTable * Placeholders for new TreeTable demos * Color for toggler * update progress spinner link * Pagination and Sections for new TreeTable * Single and Multi sort for new TreeTable * Update state on node toggle * Lazy loading TreeTable * Refactor sort demo * Loading icon for Lazy TreeTable * Lazy children loading demo for new TreeTable * Column grouping for new TreeTable * Demo code refactor * Added colgroup template support * Responsive demo for new TreeTable * Initiated scrollable for new TreeTable * Remove comma * Demo update for colgroup * More data for TreeTable demo * Implemented scrolling for new TreeTable * Remove typo * Row and Cell based styling for new TreeTable * Cosmetics * Implemented resizable columns for new TreeTable * Fixed primefaces#5804 * Column reordering for new TreeTable * Remove "new" badges from the older components * Cosmetics * Toggleable columns for new TreeTable * Selection for new TreeTable * Source code for selection demo * Name refactor for TreeTable directives * ContextMenu integration for new TreeTable * Implemented checkbox selection for the new TreeTable * Doc update * Header checkbox support for new TreeTable to toggle all nodes * Incell editing for new TreeTable * Started documentation for new TreeTable * Documentation fixes * Documentation update for TreeTable * Documentation for new TreeTable * Fixed typos * Fixed primefaces#5446 * Fixed primefaces#5706 * Remove unused section * Fixed primefaces#5657 * Fixed primefaces#5618 * Cosmetics for Demo * Set version * New iteration * Initiated PrimeIcons for PrimeNG * Fixed primefaces#3746 * Use PrimeIcons for the remaining components * Updated demos to use PrimeIcons * Cosmetic changes due to new PrimeIcons * Bigger loader icon * Doc update * Issue template update * Fixed primefaces#5853 * Fixed primefaces#5854 * Fixed primefaces#5829 * Chart doc typos. Fix for set sizing in responsive mode. * Made width also work in responsive mode, then forgot to update docs. * Fixes the turbo table scrollbar overlapping the paginator. * accessibility(accordion): correctly using of role attribute * ChartJS generateLegend need to return the HTML string. * Documentation for PrimeIcons * Demo fixes * Fixed primefaces#5751 * Fixed icons * Convert NodeList to array * Fixed primefaces#5847 * Add ecuador * Update version at footer * Doc update * Set version * New dev version * Fixed primefaces#5867 * Fixed primefaces#5211 * Readme update * Showcase split button fix * Fixed primefaces#5882 * PrimeIcons fix * Remove deprecated components from demo menu * PrimeIcons fix * Remove unused property * Fixed primefaces#5387 * Fixed primefaces#5368 * Fixed primefaces#5359 * Fixed primefaces#5329 * Fixed icon name * Fixed primefaces#5891 * Fixed primefaces#4124 - Maximizable Dialog * Block scroll * Update to new PrimeIcons * Cosmetics * Fixed primefaces#5893 * Doc update * Fixed primefaces#5348 * Refactor * Animation for dialog maximize * Demo update * Version at footer * Remove deprecated lazy prop from tabview * Set version * New version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Type: Bug
Issue contains a bug related to a specific component. Something about the component is not working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
###Defect Fixes
When running aot and fullTemplateTypeCheck is set to true in Angular 5 it is throwing the exception