TurboTable with virtualScroll not display records when totalRecords is set after ngOnInit - patch 2 with Observable #5319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Below descripted issue are corrected now using observables. I hope this changes are ok. Performance are very good with these changes and are not be affected before i maked. ###Defect Fixes In all my projects, where are datatables with virtualscroll, totalRecords it's initialized dynamically when records and total of records are received from server request. Without this feature I cannot migrate to TurboTable. In present turbotable run only if totalRecords are initialized static or in ngOnInit.
|
Merged manually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below descripted issue are corrected now using observables. I hope this changes are ok. Performance are very good with these changes and are not be affected before i maked.
###Defect Fixes
In all my projects, where are datatables with virtualscroll, totalRecords it's initialized dynamically when records and total of records are received from server request. Without this feature I cannot migrate to TurboTable. In present turbotable run only if totalRecords are initialized static or in ngOnInit.
###Defect Fixes
When submitting a PR, please also create an issue documenting the error.
###Feature Requests
Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.