Fix for issue 4755 #4977
Merged
Fix for issue 4755 #4977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A fix for the issue discussed in primefaces#4755. A case where the previous code doesn´t work is if minDate currentMonth is January, i.e. 0.
blackholegalaxy
approved these changes
Jan 27, 2018
TarasKovalenko
suggested changes
Feb 7, 2018
| @@ -352,7 +352,8 @@ export class Calendar implements AfterViewInit,AfterViewChecked,OnInit,OnDestroy | |||
|
|
|||
| set minDate(date: Date) { | |||
| this._minDate = date; | |||
| if(this.currentMonth != null && this.currentYear) { | |||
|
|
|||
| if(this.currentMonth != undefined && this.currentMonth != null && this.currentYear) { | |||
There was a problem hiding this comment.
Hey guys,
I think (this.currentMonth && this.currentYear) result will be the same but more simplify this condition.
There was a problem hiding this comment.
Hey
Not if this.currentMonth == 0 as it is in January?
|
Will fix it on our end, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for the issue discussed in #4755.
A case where the previous code doesn´t work is if minDate currentMonth is January, i.e. 0.
###Defect Fixes
When submitting a PR, please also create an issue documenting the error.
###Feature Requests
Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.
Smaller scaled feature implementations such as adding a property to a component will be considered for merging.