fix(Editor): rename next() to emit() #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, we use next for all components until now and will migrate to emit in next release. We'll do a find-replace to replace all so not merging the pr now. Thank you for the feedback. The issue is; |
atretyak1985
added a commit
to Nanitor/primeng
that referenced
this pull request
Jul 18, 2020
atretyak1985
pushed a commit
to Nanitor/primeng
that referenced
this pull request
Jul 18, 2020
Make device details device info collapsible primefaces#146
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change, but it's a fix since
next()was deprecated long ago for EventEmitter, instead we should be usingemit(). See angular/angular#5302.PS : I found out about this component through twitter and by digging in the code I saw this. I hope this it's not a problem.
PS2 : Sorry if I missed some guidelines, but I didn't see any contribution guide in your repo, I hope also not being doing anything wrong.
Cheers!