Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#14503 - fix: selecting dropdown option should reset filter #14528

Conversation

mlz11
Copy link

@mlz11 mlz11 commented Jan 10, 2024

This PR helps solve #14503.

Copy link

vercel bot commented Jan 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2024 11:32am

@cetincakiroglu
Copy link
Contributor

Hi,

Could you please resolve the conflicts so we can merge safely?

@cetincakiroglu cetincakiroglu added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Feb 23, 2024
@mlz11 mlz11 force-pushed the fix/selecting-dropdown-option-should-reset-filter branch from 29f487f to 90e1090 Compare February 28, 2024 11:32
@mlz11
Copy link
Author

mlz11 commented Feb 28, 2024

Hi,

Could you please resolve the conflicts so we can merge safely?

Done @cetincakiroglu

@mlz11
Copy link
Author

mlz11 commented Mar 12, 2024

@cetincakiroglu little 🆙 😄

@cetincakiroglu
Copy link
Contributor

Hi,

Thanks a lot for the effort and support!

Dropdown component has resetFilterOnHide input and setting it true resets the filter. Closing the PR since this feature is already exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants