Field undefined extended sub-property protection #1182
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ng2 elvis-operator style protection for data field sub-properties that could be undefined to help prevent
Cannot read property 'X' of undefined
exceptions.For example:
In the following datatable column declaration, primeng datatables would throw a
Cannot read property 'c' of undefined
exception ifb
wasundefined
. It is often the case that extended field sub-properties are present for some collections/rows, and not present for others. This PR solves this problem, while still allowing primeng datatables' built-in features that rely on the fully-qualifiedfield
property (such as sorting and filtering) to work correctly:<p-column field="a.b.c" header="C"></p-column>