fix(primeng/table): invalid unsubscribe from events #11551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cetincakiroglu
added
the
Status: Pending Review
|
Hi @volvachev, Thanks for your effort and contribution, however we cannot merge this pull request because it does not fit our code structure. So I'll close this one. We appreciate your support. |
cetincakiroglu
removed
the
Status: Pending Review
|
Hi @cetincakiroglu , is it closed because of |
|
Hi @volvachev, Good catch! Could you please send this PR again after updating it? (Note: please don't use the arrow function in global methods) Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11414.