Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabMenu Templating not working #8031

Closed
CC84 opened this issue Aug 7, 2019 · 3 comments
Closed

TabMenu Templating not working #8031

CC84 opened this issue Aug 7, 2019 · 3 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@CC84
Copy link

CC84 commented Aug 7, 2019

[x ] bug report

https://stackblitz.com/edit/angular-hnheds

Current behavior
When only importing TabMenuModule the templating is not working. TabMenuModule is missing an SharedModule export so pTemplate Directive is not known.

Expected behavior
Templating should work.

Minimal reproduction of the problem with instructions
https://stackblitz.com/edit/angular-hnheds

What is the motivation / use case for changing the behavior?
Should work like documented.

Please tell us about your environment:
not important

  • Angular version: 8.2.0

  • PrimeNG version: 8.0.2

  • Browser: all

  • Language: all

  • Node (for AoT issues): node --version = 10.x not important

@yigitfindikli
Copy link
Contributor

Hi @CC84 ,
Seems to be your angular.json not correct (stackblitz demo). Can you create sample with https://stackblitz.com/github/primefaces/primeng-issue-template .
Also you can look this working sample https://stackblitz.com/edit/github-fe5ykq

@CC84
Copy link
Author

CC84 commented Sep 3, 2019

No it's not an issue with the angular.json.
It's an issue with an missing export. The sample you linked is working cause there are imported all prime modules. A lot of them are exporting the SharedModule and so fix the issue. But when you only import the TabMenuModule, there is no SharedModule Export and so pTemplate is missing.
I've modified your working sample by just removing unneccessary imports: https://stackblitz.com/edit/github-fe5ykq-gvura4?file=src/app/app.module.ts => Templating ist no longer working.

I also tried to reproduce the issue with the issue-template, but there i wasn't able to get TabMenu working at all, maybe this is cause the referenced versions ( at least prime (8.0.0) and Angular (8.0.3) are rather old.

@yigitfindikli
Copy link
Contributor

Thanks for the sample.
Best Regards.

@yigitfindikli yigitfindikli self-assigned this Sep 4, 2019
@yigitfindikli yigitfindikli added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Sep 4, 2019
@yigitfindikli yigitfindikli added this to the 8.0.3 milestone Sep 4, 2019
JacobSiegle pushed a commit to JacobSiegle/primeng that referenced this issue Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants