Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Dialog icons for easier customization #6102

Closed
jc-white opened this issue Jul 19, 2018 · 2 comments
Closed

Expose Dialog icons for easier customization #6102

jc-white opened this issue Jul 19, 2018 · 2 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@jc-white
Copy link

If you have a PrimeNG PRO Support subscription please post your issue at;

https://pro.primefaces.org

where our team will respond within 4 business hours.

If you do not have a PrimeNG PRO Support subscription, fill-in the report below. Please note that
your issue will be added to the waiting list of community issues and will be reviewed on a first-come first-serve basis, as a result, the support team is unable to guarantee a specific schedule on when it will be reviewed. Thank you for your understanding.

Current Waiting Time: ~8 weeks.

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[x] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
Please demonstrate your case at stackblitz by using the issue template below. Issues without a test case have much less possibility to be reviewd in detail and assisted.

https://stackblitz.com/github/primefaces/primeng-issue-template

Current behavior
p-dialog header buttons (maximize, close, etc) use hardcoded primeicons and there is no way to use an alternative such as font-awesome. I would like to have consistent icons and not have to install primeicons in addition to font-awesome.

Expected behavior
Would like to be able to override these icons with another library via component inputs. Currently I have to extend the component and override the template, which seems like overkill for simply overriding an icon.

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

  • Angular version: 5.X
    6.x

  • PrimeNG version: 5.X
    6.0.1

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

  • Language: [all | TypeScript X.X | ES6/7 | ES5]

  • Node (for AoT issues): node --version =

@cagataycivici
Copy link
Member

You can override them with css but sure we can expose them as props.

@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jul 23, 2018
@cagataycivici cagataycivici changed the title No way to override p-dialog icons Expose Dialog icons for easier customization Jul 23, 2018
@jc-white
Copy link
Author

Perfect, thanks @cagataycivici!

gasparbarancelli pushed a commit to gasparbarancelli/primeng that referenced this issue Jan 8, 2019
gasparbarancelli pushed a commit to gasparbarancelli/primeng that referenced this issue Jan 8, 2019
gasparbarancelli pushed a commit to gasparbarancelli/primeng that referenced this issue Jan 8, 2019
cagataycivici added a commit that referenced this issue Jan 23, 2019
Expose Dialog icons for easier customization #6102
@cagataycivici cagataycivici added this to the 7.0.5 milestone Jan 23, 2019
@cagataycivici cagataycivici self-assigned this Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants