Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: p-dropdown does not contain children with role=option #5809

Closed
paraskt opened this issue May 28, 2018 · 0 comments
Closed

Accessibility: p-dropdown does not contain children with role=option #5809

paraskt opened this issue May 28, 2018 · 0 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@paraskt
Copy link

paraskt commented May 28, 2018

If you have a PrimeNG PRO Support subscription please post your issue at;

https://pro.primefaces.org

where our team will respond within 4 business hours.

If you do not have a PrimeNG PRO Support subscription, fill-in the report below. Please note that
your issue will be added to the waiting list of community issues and will be reviewed on a first-come first-serve basis, as a result, the support team is unable to guarantee a specific schedule on when it will be reviewed. Thank you for your understanding.

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
Please demonstrate your case at stackblitz by using the issue template below. Issues without a test case have much less possibility to be reviewd in detail and assisted.

https://stackblitz.com/github/primefaces/primeng-issue-template

Current behavior
p-dropdown must contain children with role=option. As per following certain ARIA roles must contain particular children.
https://dequeuniversity.com/rules/axe/2.6/aria-required-children

Expected behavior
p-dropdown must contain children with role option. This will cause screen readers to not know about how many elements are there in the dropdown/listbox
For each role, WAI-ARIA explicitly defines which child and parent roles are allowable and/or required. ARIA roles missing required child roles will not be able to perform the accessibility functions intended by the developer.

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?
For each role, WAI-ARIA explicitly defines which child and parent roles are allowable and/or required. ARIA roles missing required child roles will not be able to perform the accessibility functions intended by the developer.

Please tell us about your environment:

  • Angular version: 5.X
    5.1.3

  • PrimeNG version: 5.X
    5.2.5

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
    Chrome, edge

  • Language: [all | TypeScript X.X | ES6/7 | ES5]

  • Node (for AoT issues): node --version =

@cagataycivici cagataycivici self-assigned this Dec 31, 2018
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Dec 31, 2018
@cagataycivici cagataycivici added this to the 7.0.5 milestone Dec 31, 2018
gasparbarancelli pushed a commit to gasparbarancelli/primeng that referenced this issue Jan 9, 2019
cagataycivici added a commit that referenced this issue Jan 23, 2019
Accessibility: p-dropdown does not contain children with role=option #5809
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants