Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog mask is not removed on destroy. #428

Closed
TheSilvermind opened this issue May 27, 2016 · 4 comments
Closed

Dialog mask is not removed on destroy. #428

TheSilvermind opened this issue May 27, 2016 · 4 comments
Assignees
@cagataycivici
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
1.0.0-beta.7

Comments

@TheSilvermind
Copy link

TheSilvermind commented May 27, 2016 •
edited
Loading

Version; "primeng": "1.0.0-beta.6"

It seems when Dialog.prototype.ngOnDestroy is called that the mask is not removed from the dom.
I suggest to change this code at line 183:
Dialog.prototype.ngOnDestroy = function () {
// new
this.disableModality();
// old
// this.mask = null;
...
}
@TheSilvermind TheSilvermind changed the title Dialog mask is not removed on destroy. ui-widget-overlay ui-dialog-mask Dialog mask is not removed on destroy. May 27, 2016
@Chadley08
Copy link

I am also having this issue.

@TheSilvermind
Copy link
Author

TheSilvermind commented May 27, 2016 •
edited
Loading

@Chadley08
You can change line 184 in dialog.js from
this.mask = null;
to
if (this.disableModality) {
this.disableModality();
}

@Chadley08
Copy link

Confirmed this fix as working for me.

@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label May 28, 2016
@cagataycivici cagataycivici added this to the 1.0.0-beta.7 milestone May 28, 2016
@cagataycivici cagataycivici self-assigned this May 28, 2016
@cagataycivici
Copy link
Member

Fix checked in, thank you.

atretyak1985 pushed a commit to Nanitor/primeng that referenced this issue Jul 18, 2020
Merge pull request primefaces#428 from atretyak1985/issue_#NNTR-402
9181841 
[NNTR-402]Asset - agent update does not close the window
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
1.0.0-beta.7
Development

No branches or pull requests
3 participants
@cagataycivici @TheSilvermind @Chadley08