Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using @angular/router-deprecated instead of @angular/router is causing issues in several components #374

Closed
joe380 opened this issue May 18, 2016 · 8 comments

Comments

@joe380
Copy link

joe380 commented May 18, 2016

Components which are going to have problems:

  • breadcrumb
  • contextmenu
  • megamenu
  • menu
  • menubar
  • panelmenu
  • slidemenu
  • tabmenu
  • tieredmenu

Is there a way to used these components with new @angular/router?

@robert-king
Copy link

robert-king commented May 19, 2016

same problem with autocomplete which is what i really need in my current project.

@joe380
Copy link
Author

joe380 commented May 19, 2016

A quick fix (temporary solution) is to provide also deprecated router:

in package.json you need both:

  • "@angular/router": "^2.0.0-rc.1"
  • "@angular/router-deprecated": "^2.0.0-rc.1"

in bootstrap file you do it like this:

  • import { ROUTER_PROVIDERS } from '@angular/router'
  • import { ROUTER_PROVIDERS as ROUTER_PROVIDERS_D} from '@angular/router-deprecated'

bootstrap(AppComponent, [ //build in providers HTTP_PROVIDERS, ROUTER_PROVIDERS, ROUTER_PROVIDERS_D, //app injectables APP_ACTIONS, provideStore(APP_REDUCERS), instrumentStore(), provide(AppStateStore, {useExisting:Store}), devtoolsConfig({ position: 'bottom', visible: true, size: 0.3 }) ]) .catch(err => console.error(err));

@ajayambre
Copy link

Same issue. Please upgrade to RC1 and remove @angular/router-deprecated dependency.

@wernerjacobs
Copy link

Experienced the same issue, workaround from joe380 did solve the problem for the moment.

@ammar91
Copy link

ammar91 commented May 20, 2016

Same issue.
@joe380 Thanks for the workaround .

However, I'm using Contextmenu so when I right click, the position for menu seems to be off. It's open a bit far right and bottom. Like If I right click on first row 5th column, it open up in 2nd row and far right (see image below).
Any thoughts?

screen

@brian428
Copy link
Contributor

+1. Mixing the use of the deprecated router with the current one (used by my apps outside of PrimeNG) is really not a fun problem to deal with.

@IsuruCham
Copy link

After the new update to v.1.0.0-beta.7 (#388) , this issue is resolved.
Thanks primeng team.

@cagataycivici
Copy link
Member

Closing as tomorrow's beta9 even use the new new new router of RC3.

atretyak1985 pushed a commit to Nanitor/primeng that referenced this issue Jul 18, 2020
Audit report: Update to show compliance framework and controls, remov…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants