Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onRemove callback to FileUpload #2822

Closed
white-cap opened this issue May 19, 2017 · 2 comments
Closed

Add onRemove callback to FileUpload #2822

white-cap opened this issue May 19, 2017 · 2 comments
Assignees
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone

Comments

@white-cap
Copy link

white-cap commented May 19, 2017

The onClear() callback at fileUpload doesn't work for
div><button type="button" icon="fa-close" pButton (click)="remove(i)"></button></div>

<p-fileUpload  chooseLabel="Choose a logo"  (onSelect)="onSelectLogo($event)" (onClear)="onClear()" >
</p-fileUpload>

@component....
....
public onClear() {
        console.log('trigger')
}

[X] feature request

Current behavior

it works only for cancel button
Expected behavior

create a callback for this

  • Angular version: 4
  • PrimeNG version: 4.0.0
@white-cap white-cap changed the title onClear() at fileUpload doesn't work #BUG #fileUpload onClear() at fileUpload doesn't work May 19, 2017
@white-cap white-cap changed the title #BUG #fileUpload onClear() at fileUpload doesn't work #featureRequest #fileUpload onClear() at fileUpload May 19, 2017
@upmauro
Copy link
Contributor

upmauro commented May 23, 2017

I can't reproduce, can you create a plunkr to help us?

cagataycivici added a commit that referenced this issue May 26, 2017
Feature #2822 file upload onItemClear callback
@cagataycivici cagataycivici changed the title #featureRequest #fileUpload onClear() at fileUpload Add onRemove callback to FileUpload May 26, 2017
@cagataycivici cagataycivici self-assigned this May 26, 2017
@cagataycivici cagataycivici added the Type: New Feature Issue contains a new feature or new component request label May 26, 2017
@cagataycivici cagataycivici added this to the 4.0.2 milestone May 26, 2017
@cagataycivici
Copy link
Member

Changed PR to onRemove callback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Development

No branches or pull requests

3 participants