-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with Electron #256
Comments
Please remove your jquery and only include;
|
When I include only primeui-ng-all.js, I get the error on an other line, within the file on line 9846. So that doesn't really help. Maybe I have to mention it's a Electron app. But that must not make a difference. |
maybe i'm a captain obvious, but i think you try to use that framework in non-angular app. |
It's an angular app. But that must not change the fact that I get an error On Wed, Apr 27, 2016 at 9:08 AM Aigars Zeiza [email protected]
|
It is probably because of Electron, we also faced with it but could not find enough time to provide a sample with electron. I'll ask my colleague to work on this to setup a quickstart with electron. @Mrtcndkn Please take over. |
Hi, |
I've checked it out but, I'm not able to build it successfully. So Can you explain in short What I have to do to make primeng work in electron? I've tried to import the script like so "import 'script!node_modules/primeui/primeui-ng-all.min.js';". But this gives me a new error. Now I get "Error: ReferenceError: $ is not defined(…)" |
Ok I have found a solution after a long search. It was indeed not primeng related but Electron related. I've installed jquery through npm
It's a bit strange to load jquery and then load the -all version. But if I load the primeui-ng.js than I get the error again. And important to add primeng to the packages in the system config
So, I hope this will help other people who are having the same problem. |
I solved the problems according to that issue but i have to change node-integration:false in my case but it seems you handled it differently.I'm glad to hear that you find a solution. |
Idd when you change node-integration to false it loads like a normal webpage in the browser. So there are no issues. |
Yes it's not a problem for me but if someone try to use other third parties or some api's which uses node it can cause some issues |
Ok I feel like an ass now. Apparently the only thing I had to do was to add
to the package. You don't need to reference the files in a script tag. So you can remove
and it still works. And no errors. Sorry for all the fuss. |
No worries it's a good practice for anyone =) |
Guys, I need your help, I did tests and I liked PrimeNG, mainly for including jQuery, which is where the core of the application I'm building was developed, so much so that I ended up buying a premium template. But to make my system really be useful it needs to have a desktop version, in the case with Electron. I saw the @Mrtcndkn PrimeNG-Electron repository but I noticed that it is outdated and I could not run the example application included in the template I bought in it. Are you aware of any boilerplate project with Electron + Angular + PrimeNg set works perfectly, without conflicts? |
Not at the moment but maybe we can update that existing electron-primeng example to the latest versions. @AlexVFornazieri |
I'm trying to install primeng but I get the following error
Uncaught ReferenceError: jQuery is not defined
Chrome says it's because of this line "jQuery.uaMatch = function( ua ) {" (line 112)
I've imported jquery before.
But even in the primeui-ng-all file this error pops up.
Did I forgot to add something?
my dependencies
The text was updated successfully, but these errors were encountered: