Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pFocusTrap: "aria-hidden-focus" accessibility rule violation #16042

Closed
andrey-post opened this issue Jul 17, 2024 · 0 comments · Fixed by #16058 · 4 remaining pull requests
Closed

pFocusTrap: "aria-hidden-focus" accessibility rule violation #16042

andrey-post opened this issue Jul 17, 2024 · 0 comments · Fixed by #16058 · 4 remaining pull requests
Assignees
@mehmetcetin01140
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA PRO Support Issue was reported by PRO User
Milestone
17.18.5

Comments

@andrey-post
Copy link

Describe the bug

#15482
New implementation of pFocusTrap has aria-hidden-focus accessibility rule violation:
image

Environment

image

Reproducer

No response

Angular version

17.3.11

PrimeNG version

17.18.4

Build / Runtime

TypeScript

Language

TypeScript

Node version (for AoT issues node --version)

18.20.2

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to https://primeng.org/focustrap
  2. Install Axe DevTools accessibility scanner extension
  3. Open dev tools and run Full Page check
  4. Observe aria-hidden-focus rule violation by invisible span elements added by pFocusTrap directive

https://dequeuniversity.com/rules/axe/4.9/aria-hidden-focus?application=AxeChrome

Expected behavior

pFocusTrap should work without accessibility rules violations.
@andrey-post andrey-post added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 17, 2024
@mehmetcetin01140 mehmetcetin01140 added PRO Support Issue was reported by PRO User Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 18, 2024
@mehmetcetin01140 mehmetcetin01140 self-assigned this Jul 18, 2024
@mehmetcetin01140 mehmetcetin01140 added this to the 17.18.5 milestone Jul 18, 2024
mehmetcetin01140 added a commit that referenced this issue Jul 18, 2024
@mehmetcetin01140
Fixed #16042 - pFocusTrap: aria-hidden-focus accessibility rule viola…
43e4613 
…tion
@mehmetcetin01140 mehmetcetin01140 mentioned this issue Jul 18, 2024
Merged
cetincakiroglu added a commit that referenced this issue Jul 18, 2024
@cetincakiroglu
Merge pull request #16058 from primefaces/issue-16042
f503e11 
Fixed #16042 - pFocusTrap: aria-hidden-focus accessibility rule viola…
@Rodolphe33 Rodolphe33 mentioned this issue Aug 9, 2024
Open
@lakshamanr lakshamanr mentioned this issue Aug 9, 2024
Closed
This was referenced Aug 16, 2024
Open
Open
This was referenced Aug 30, 2024
Open
Open
This was referenced Sep 8, 2024
Open
Open
@Rodolphe33 Rodolphe33 mentioned this issue Sep 20, 2024
Open
@Rodolphe33 Rodolphe33 mentioned this issue Oct 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA PRO Support Issue was reported by PRO User
Projects
None yet
Milestone
17.18.5
Development

Successfully merging a pull request may close this issue.

Fixed #16042 - pFocusTrap: aria-hidden-focus accessibility rule viola… primefaces/primeng
[Snyk] Upgrade primeng from 17.14.1 to 17.18.5 Rodolphe33/gestion-personnel
[Snyk] Upgrade primeng from 17.14.1 to 17.18.6 Rodolphe33/gestion-personnel
[Snyk] Upgrade primeng from 17.14.1 to 17.18.7 Rodolphe33/gestion-personnel
[Snyk] Upgrade primeng from 17.14.1 to 17.18.8 Rodolphe33/gestion-personnel
[Snyk] Upgrade primeng from 17.14.1 to 17.18.9 Rodolphe33/gestion-personnel
[Snyk] Upgrade: , , , , , , , , , tslib, , primeng, zone.js Rodolphe33/gestion-personnel
[Snyk] Upgrade: , , , , , , , , , tslib, , primeng, zone.js Rodolphe33/gestion-personnel
[Snyk] Upgrade: , , , , , , , , , tslib, , primeng, zone.js Rodolphe33/gestion-personnel
[Snyk] Upgrade primeng from 17.14.1 to 17.18.10 Rodolphe33/gestion-personnel
2 participants
@mehmetcetin01140 @andrey-post