Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p-table passing any expandedRowKeys will cause table to not expand anymore #15270

Closed
ymg2006 opened this issue Apr 15, 2024 · 3 comments
Closed

p-table passing any expandedRowKeys will cause table to not expand anymore #15270

ymg2006 opened this issue Apr 15, 2024 · 3 comments
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.14.0

Comments

@ymg2006
Copy link
Contributor

ymg2006 commented Apr 15, 2024

Describe the bug

p-table binding any [expandedRowKeys] will cause table to not expand anymore.

Environment

Angular CLI: 17.3.3
Node: 20.12.1
Package Manager: npm 10.5.0
OS: win32 x64

Package Version

@angular-devkit/architect 0.1703.3 (cli-only)
@angular-devkit/core 17.3.3 (cli-only)
@angular-devkit/schematics 17.3.3 (cli-only)
@schematics/angular 17.3.3 (cli-only)

Reproducer

No response

Angular version

17.3.3

PrimeNG version

17.13.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

v20.12.1

Browser(s)

No response

Steps to reproduce the behavior

just bind any object to expandedRowKeys it will break expanding of table

Expected behavior

Work like 17.12.0, I will create a pull request to fix.
@ymg2006 ymg2006 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 15, 2024
ymg2006 pushed a commit to ymg2006/primeng that referenced this issue Apr 15, 2024
@codizen-dev
fixes issue primefaces#15270: p-table passing any expandedRowKeys wil…
ef796c5 
…l cause table to not expand anymore

The object of type { [s: string]: boolean } is not transform: booleanAttribute....
@ymg2006 ymg2006 mentioned this issue Apr 15, 2024
Closed
@ymg2006
Copy link
Contributor Author

ymg2006 commented Apr 15, 2024

#15271 solves this issue
#15271

@BGBRWR
Copy link
Contributor

BGBRWR commented Apr 15, 2024

#15243 fixes this.

@cetincakiroglu
Copy link
Contributor

Fixed in #15243

@cetincakiroglu cetincakiroglu added this to the 17.14.0 milestone Apr 18, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.14.0
Development

Successfully merging a pull request may close this issue.

The object of type { [s: string]: boolean } is not transform: booleanAttribute ymg2006/primeng
3 participants
@ymg2006 @BGBRWR @cetincakiroglu