Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flags icons for US is wrong #15184

Closed
cetincakiroglu opened this issue Mar 28, 2024 · 4 comments · Fixed by #15234
Closed

Flags icons for US is wrong #15184

cetincakiroglu opened this issue Mar 28, 2024 · 4 comments · Fixed by #15234
Assignees
@cetincakiroglu
Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.13.0

Comments

@cetincakiroglu
Copy link
Contributor

See: https://github.com/orgs/primefaces/discussions/1534
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working LTS-PORTABLE Issue's fix will be ported to supported LTS versions labels Mar 28, 2024
@cetincakiroglu cetincakiroglu added this to the 17.13.0 milestone Mar 28, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 28, 2024
@cetincakiroglu cetincakiroglu removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 28, 2024
@melloware
Copy link
Member

I will update PrimeReact and PrimeFaces CSS and PNG @cetincakiroglu when you update this one

@cetincakiroglu cetincakiroglu self-assigned this Mar 29, 2024
cetincakiroglu added a commit that referenced this issue Apr 9, 2024
@cetincakiroglu
Fixed #15184 - Update flags
161b784
@cetincakiroglu cetincakiroglu mentioned this issue Apr 9, 2024
Merged
cetincakiroglu added a commit that referenced this issue Apr 9, 2024
@cetincakiroglu
Merge pull request #15234 from primefaces/issue-15184
13b92f3 
Fixed #15184 - Update flags
@cetincakiroglu
Copy link
Contributor Author

cetincakiroglu commented Apr 9, 2024 •
edited
Loading

@melloware I've updated the flags_responsive.png from primereact cdn also. It should be okay now, but flags.css might need to be updated.

@melloware
Copy link
Member

Thank you I will check today.

@melloware
Copy link
Member

@cetincakiroglu i am confused the image looks the same with an incorrect USA flag?

I did this yesterday in PrimeReact which has correct American flag and MIT license

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cetincakiroglu cetincakiroglu

Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.13.0
Development

Successfully merging a pull request may close this issue.

Fixed #15184 - Update flags primefaces/primeng
2 participants
@melloware @cetincakiroglu