Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toast: closeIcon on message is outside of button #13707

Closed
ethanolree opened this issue Sep 20, 2023 · 3 comments · Fixed by #13727
Closed

Toast: closeIcon on message is outside of button #13707

ethanolree opened this issue Sep 20, 2023 · 3 comments · Fixed by #13727
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@ethanolree
Copy link

Describe the bug

Adding a customIcon to toast messages causes the icon to appear outside of the button

image

image

Environment

Angular with PrimeNG

Reproducer

No response

Angular version

16.2.5

PrimeNG version

16.3.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18

Browser(s)

No response

Steps to reproduce the behavior

Add a closeIcon to any toast message

Expected behavior

Icon will appear inside of the toast button

@ethanolree ethanolree added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 20, 2023
@ashikjs
Copy link
Contributor

ashikjs commented Sep 24, 2023

@ethanolree can you make any reproducible code and share with us

@ethanolree
Copy link
Author

ethanolree commented Sep 24, 2023

@ashikjs

HTML:
<p-toast></p-toast>

TS:
this.messageService.add({severity: 'success', summary: 'Success', detail: 'Message Content', closeIcon: 'pi pi-heart'});

any toast using closeIcon

@ashikjs
Copy link
Contributor

ashikjs commented Sep 25, 2023

@ethanolree ya, got it. Thanks for your response.
I solve it and make a PR for this issues and waiting to approved from Primeng Core team.

Btw: you should use only icon name like pi-heart or pi-times.

@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 25, 2023
@cetincakiroglu cetincakiroglu added this to the 16.4.0 milestone Sep 25, 2023
cetincakiroglu added a commit that referenced this issue Sep 25, 2023
…ustom-not-working

fix: #13707 || Toast: closeIcon on message is outside of button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants